From bd2871a43aba4d67bfba02210559f6a6d9c58dc2 Mon Sep 17 00:00:00 2001 From: Paul Stewart Date: Tue, 13 Jul 2010 07:59:15 -0700 Subject: [PATCH] Fix duplicate sever-port bug cros_copy_upgrade_server had a bug where it would always start servers on port 8081 regrdless of whether that port was free. This was a bug in the "get next free port" code. BUG=chromium-os:4776 TEST=Reran multiple instances at once, run netstat -nlt Review URL: http://codereview.chromium.org/2975006 --- bin/cros_copy_upgrade_server.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/cros_copy_upgrade_server.sh b/bin/cros_copy_upgrade_server.sh index 5b375c88d2..49abf19790 100755 --- a/bin/cros_copy_upgrade_server.sh +++ b/bin/cros_copy_upgrade_server.sh @@ -118,7 +118,7 @@ start_server () { # Find a TCP listen socket that is not in use ssh ${FLAGS_upgrade_server} "netstat -lnt" | awk '{ print $4 }' > $portlist server_port=8081 - while grep -q ":${port}$" $portlist; do + while grep -q ":${server_port}$" $portlist; do server_port=$[server_port + 1] done rm -f $portlist