Merge pull request #404 from marineam/gov

oem/ami: add support for publishing AMIs in us-gov-west-1

oem/ami/copy_ami.sh

@@ -71,7 +71,7 @@ fi
 zoneurl=http://instance-data/latest/meta-data/placement/availability-zone
 zone=$(curl --fail -s $zoneurl)
 region=$(echo $zone | sed 's/.$//')
-export EC2_URL="http://ec2.${region}.amazonaws.com"
+export EC2_URL="https://ec2.${region}.amazonaws.com"
 
 if [[ -z "$AMI" ]]; then
     search_name=$(clean_version "CoreOS-$GROUP-$VER")
@@ -96,7 +96,7 @@ else
 fi
 
 if [[ ${#REGIONS[@]} -eq 0 ]]; then
-    REGIONS=( "${ALL_REGIONS[@]}" )
+    REGIONS=( "${MAIN_REGIONS[@]}" )
 fi
 
 # The name has a limited set of allowed characterrs

oem/ami/import.sh

@@ -118,7 +118,7 @@ if [ -z "$akiid" ]; then
    exit 1
 fi
 
-export EC2_URL="http://ec2.${region}.amazonaws.com"
+export EC2_URL="https://ec2.${region}.amazonaws.com"
 echo "Building AMI in zone ${EC2_IMPORT_ZONE}"
 
 tmpimg=$(mktemp)

oem/ami/prod-publish.sh

@@ -10,6 +10,4 @@ if [ -z "$GROUP" -o -z "$VER" ]; then
   exit 1
 fi
 
-set -e
-source $DIR/marineam-auth.sh
 $DIR/publish_ami.sh -b $BOARD -g $GROUP -V $VER

oem/ami/prod.sh

@@ -16,3 +16,6 @@ args="-b $BOARD -g $GROUP -V $VER"
 $DIR/import.sh ${args}
 $DIR/test_ami.sh -v ${args}
 $DIR/copy_ami.sh ${args}
+
+source $DIR/ami-builder-us-gov-auth.sh
+$DIR/import.sh ${args}

oem/ami/publish_ami.sh

@@ -55,6 +55,13 @@ fi
 search_name=$(clean_version "CoreOS-$GROUP-$VER")
 declare -A AMIS HVM_AMIS
 for r in "${ALL_REGIONS[@]}"; do
+    # Hacky but avoids writing an indirection layer to handle auth...
+    if [[ "${r}" == "us-gov-west-1" ]]; then
+        source $DIR/ami-builder-us-gov-auth.sh
+    else
+        source $DIR/marineam-auth.sh
+    fi
+
     AMI=$(ec2-describe-images --region=${r} -F name="${search_name}" \
         | grep -m1 ^IMAGE | cut -f2) || true
     if [[ -z "$AMI" ]]; then
@@ -86,20 +93,27 @@ publish_ami() {
     local r="$1"
     local virt_type="$2"
     local r_amiid="$3"
-    local r_snapshotid=$(ec2-describe-images --region="$r" "$r_amiid" \
-        | grep -E '^BLOCKDEVICEMAPPING.*/dev/(xv|s)da' | cut -f5) || true
 
-    # run in a subshell, the -e flag doesn't get inherited
+    if [[ "${r}" == "us-gov-west-1" ]]; then
-    set -e
+        source $DIR/ami-builder-us-gov-auth.sh
-
+    else
-    if [[ -z "${r_snapshotid}" ]]; then
+        source $DIR/marineam-auth.sh
-        echo "$0: Cannot find snapshot id for $r_amiid in $r" >&2
-        return 1
     fi
 
-    echo "Sharing snapshot $r_snapshotid in $r with Amazon"
+    # Only required for publishing to the marketplace
-    ec2-modify-snapshot-attribute --region "$r" \
+    if [[ "$r" == "us-east-1" ]]; then
-        "$r_snapshotid" -c --add 679593333241
+        local r_snapshotid=$(ec2-describe-images --region="$r" "$r_amiid" \
+            | grep -E '^BLOCKDEVICEMAPPING.*/dev/(xv|s)da' | cut -f5) || true
+
+        if [[ -z "${r_snapshotid}" ]]; then
+            echo "$0: Cannot find snapshot id for $r_amiid in $r" >&2
+            return 1
+        fi
+
+        echo "Sharing snapshot $r_snapshotid in $r with Amazon"
+        ec2-modify-snapshot-attribute --region "$r" \
+            "$r_snapshotid" -c --add 679593333241
+    fi
 
     echo "Making $r_amiid in $r public"
     ec2-modify-image-attribute --region "$r" \
@@ -113,19 +127,16 @@ publish_ami() {
     upload_file "${virt_type}_${r}.txt" "$r_amiid"
 }
 
-WAIT_PIDS=()
 PV_ALL=""
 for r in "${!AMIS[@]}"; do
-    publish_ami "$r" pv "${AMIS[$r]}" &
+    publish_ami "$r" pv "${AMIS[$r]}"
-    WAIT_PIDS+=( $! )
     PV_ALL+="|${r}=${AMIS[$r]}"
 done
 PV_ALL="${PV_ALL#|}"
 
 HVM_ALL=""
 for r in "${!HVM_AMIS[@]}"; do
-    publish_ami "$r" hvm "${HVM_AMIS[$r]}" &
+    publish_ami "$r" hvm "${HVM_AMIS[$r]}"
-    WAIT_PIDS+=( $! )
     HVM_ALL+="|${r}=${HVM_AMIS[$r]}"
 done
 HVM_ALL="${HVM_ALL#|}"
@@ -141,19 +152,6 @@ done
 AMI_ALL="${AMI_ALL%,}"
 AMI_ALL+="\n  ]\n}"
 
-# wait for each subshell individually to report errors
-WAIT_FAILED=0
-for wait_pid in "${WAIT_PIDS[@]}"; do
-    if ! wait ${wait_pid}; then
-        : $(( WAIT_FAILED++ ))
-    fi
-done
-
-if [[ ${WAIT_FAILED} -ne 0 ]]; then
-    echo "${WAIT_FAILED} jobs failed, aborting :(" >&2
-    exit ${WAIT_FAILED}
-fi
-
 upload_file "all.txt" "${PV_ALL}"
 upload_file "pv.txt" "${PV_ALL}"
 upload_file "hvm.txt" "${HVM_ALL}"

oem/ami/regions.sh

@@ -13,4 +13,9 @@ ALL_AKIS["ap-southeast-2"]=aki-c362fff9
 ALL_AKIS["ap-northeast-1"]=aki-176bf516
 ALL_AKIS["sa-east-1"]=aki-5553f448
 
+MAIN_REGIONS=( "${!ALL_AKIS[@]}" )
+
+# The following are isolated regions
+ALL_AKIS["us-gov-west-1"]=aki-1de98d3e
+
 ALL_REGIONS=( "${!ALL_AKIS[@]}" )

oem/ami/test_ami.sh

@@ -54,7 +54,7 @@ fi
 zoneurl=http://instance-data/latest/meta-data/placement/availability-zone
 zone=$(curl --fail -s $zoneurl)
 region=$(echo $zone | sed 's/.$//')
-export EC2_URL="http://ec2.${region}.amazonaws.com"
+export EC2_URL="https://ec2.${region}.amazonaws.com"
 
 if [[ -z "$AMI" && -n "$VER" ]]; then
     search_name=$(clean_version "CoreOS-$GROUP-$VER")