From b28538692c3180f9c8f2e1feb2ed57ad460f914d Mon Sep 17 00:00:00 2001 From: Chris Sosa Date: Fri, 23 Jul 2010 16:59:50 -0700 Subject: [PATCH] Need $ on same line to not eval hash as command in bash TEST=Re-ran script and saw new changes. Review URL: http://codereview.chromium.org/3032021 --- cros_mark_all_as_stable | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/cros_mark_all_as_stable b/cros_mark_all_as_stable index 3d7967bc2c..562d611014 100755 --- a/cros_mark_all_as_stable +++ b/cros_mark_all_as_stable @@ -47,8 +47,8 @@ for package in ${PACKAGES}; do eval $(${EBUILDCMD} ${ebuild_path} info) &> /dev/null || continue head_commit=$( cd "${CROS_WORKON_SRCDIR}" &&\ bash -c "${GRAB_HEAD_COMMIT_CMD}" ) || continue - egit_commit=\ - $(eval echo $(grep CROS_WORKON_COMMIT ${ebuild_path} | cut -f 2 -d '=')) ||\ + egit_commit=$(\ + eval echo $(grep CROS_WORKON_COMMIT ${ebuild_path} | cut -f 2 -d '=')) ||\ echo "No CROS_WORKON_COMMIT found in ${ebuild_path}" if [[ ${head_commit} != ${egit_commit} ]] && \ [ -n "${head_commit}" ]; then @@ -56,6 +56,8 @@ for package in ${PACKAGES}; do "HEAD ${head_commit} != CROS_WORKON_COMMIT ${egit_commit} for ${package}" PACKAGE_LIST="${PACKAGE_LIST} ${package}" COMMIT_ID_LIST="${COMMIT_ID_LIST} ${head_commit}" + elif [[ ${head_commit} = ${egit_commit} ]]; then + info "Commit id's match for ${package}" fi done