From ab9ca21ba01a0b444c5b9361e47ab5f7c4d57f3d Mon Sep 17 00:00:00 2001 From: David James Date: Tue, 6 Nov 2012 11:06:07 -0800 Subject: [PATCH] build_packages should update all packages for dependency checks. Currently, build_packages has a typo that causes it to only include "chromeos" in dependency checks. This means that if a package outside of chromeos needs to be updated in order to fix a conflict, build_packages will refuse to do that and break. This caused a build break on keybuk's machine. BUG=none TEST=Try it on keybuk's machine and verify build_packages works again. TEST=Remote trybot run. Change-Id: I1acca0be47152ba93c30ba07c0bf643650906199 Reviewed-on: https://gerrit.chromium.org/gerrit/37452 Reviewed-by: Scott James Remnant Commit-Ready: David James Tested-by: David James --- build_packages | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build_packages b/build_packages index 49365c4d2c..5d3f71ebd3 100755 --- a/build_packages +++ b/build_packages @@ -175,7 +175,8 @@ fi # Verify that all packages can be emerged from scratch, without any # backtracking. Only print the output if this step fails. info "Checking package dependencies are correct: ${PACKAGES[*]}" -if ! OUTPUT=$(emerge-${FLAGS_board} -pe --backtrack=0 ${PACKAGES} 2>&1); then +if ! OUTPUT=$(emerge-${FLAGS_board} -pe --backtrack=0 \ + "${PACKAGES[@]}" 2>&1); then printf "%s\n" "${OUTPUT}" die_notrace "emerge detected broken ebuilds. See error message above." fi