From ab4c4e1c69323f6f9f015a3e212f350f25a85d10 Mon Sep 17 00:00:00 2001
From: Hung-Te Lin <hungte@chromium.org>
Date: Mon, 19 Sep 2011 14:27:18 +0800
Subject: [PATCH] crosutils: Revert "crosutils: refine make_factory_package"

This partially reverts commit cfc4720c28a17a04ea833809178bda540d44dfa4
( http://gerrit.chromium.org/gerrit/7904 )

Currently we store the hash generated by compress_and_hash_memento_image in a
shell variable, and sub shell "(cmd)" can't export the variables. It would
require more rewriting of scripts to fix this issue, so let's first revert it.

BUG=chrome-os-partner:5979
TEST=./make_factory_package --config config/mp_factory.config
     cd ../platform/dev; python deverserver.py --factory_config mini_omaha.conf
     # then start whole factory installation process on DUT, and passed.

Change-Id: I1c7d8de61427733b1dff61dcd7e1c01fea7c4de6
Reviewed-on: http://gerrit.chromium.org/gerrit/7916
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Tammo Spalink <tammo@chromium.org>
---
 make_factory_package.sh | 55 +++++++++++++++++++++--------------------
 1 file changed, 28 insertions(+), 27 deletions(-)

diff --git a/make_factory_package.sh b/make_factory_package.sh
index a862606837..9f059ee37c 100755
--- a/make_factory_package.sh
+++ b/make_factory_package.sh
@@ -474,40 +474,41 @@ generate_omaha() {
   echo "Output omaha config to ${OMAHA_CONF}"
 
   # Get the release image.
-  ( set -e
-    cd "${RELEASE_DIR}"
-    prepare_dir "."
+  # TODO(hungte) deprecate pushd and use temporary folders
+  pushd "${RELEASE_DIR}" >/dev/null
+  prepare_dir "."
 
-    kernel="${RELEASE_KERNEL:-${RELEASE_IMAGE}:2}"
-    rootfs="${RELEASE_IMAGE}:3"
-    release_hash="$(compress_and_hash_memento_image "$kernel" "$rootfs")"
-    mv ./update.gz "${OMAHA_DATA_DIR}/rootfs-release.gz"
-    echo "release: ${release_hash}"
+  kernel="${RELEASE_KERNEL:-${RELEASE_IMAGE}:2}"
+  rootfs="${RELEASE_IMAGE}:3"
+  release_hash="$(compress_and_hash_memento_image "$kernel" "$rootfs")"
+  mv ./update.gz "${OMAHA_DATA_DIR}/rootfs-release.gz"
+  echo "release: ${release_hash}"
 
-    oem_hash="$(compress_and_hash_partition "${RELEASE_IMAGE}" 8 "oem.gz")"
-    mv oem.gz "${OMAHA_DATA_DIR}"
-    echo "oem: ${oem_hash}"
-  )
+  oem_hash="$(compress_and_hash_partition "${RELEASE_IMAGE}" 8 "oem.gz")"
+  mv oem.gz "${OMAHA_DATA_DIR}"
+  echo "oem: ${oem_hash}"
+
+  popd >/dev/null
 
   # Go to retrieve the factory test image.
-  ( set -e
-    cd "${FACTORY_DIR}"
-    prepare_dir "."
+  pushd "${FACTORY_DIR}" >/dev/null
+  prepare_dir "."
 
-    kernel="${FACTORY_IMAGE}:2"
-    rootfs="${FACTORY_IMAGE}:3"
-    test_hash="$(compress_and_hash_memento_image "$kernel" "$rootfs")"
-    mv ./update.gz "${OMAHA_DATA_DIR}/rootfs-test.gz"
-    echo "test: ${test_hash}"
+  kernel="${FACTORY_IMAGE}:2"
+  rootfs="${FACTORY_IMAGE}:3"
+  test_hash="$(compress_and_hash_memento_image "$kernel" "$rootfs")"
+  mv ./update.gz "${OMAHA_DATA_DIR}/rootfs-test.gz"
+  echo "test: ${test_hash}"
 
-    state_hash="$(compress_and_hash_partition "${FACTORY_IMAGE}" 1 "state.gz")"
-    mv state.gz "${OMAHA_DATA_DIR}"
-    echo "state: ${state_hash}"
+  state_hash="$(compress_and_hash_partition "${FACTORY_IMAGE}" 1 "state.gz")"
+  mv state.gz "${OMAHA_DATA_DIR}"
+  echo "state: ${state_hash}"
 
-    efi_hash="$(compress_and_hash_partition "${FACTORY_IMAGE}" 12 "efi.gz")"
-    mv efi.gz "${OMAHA_DATA_DIR}"
-    echo "efi: ${efi_hash}"
-  )
+  efi_hash="$(compress_and_hash_partition "${FACTORY_IMAGE}" 12 "efi.gz")"
+  mv efi.gz "${OMAHA_DATA_DIR}"
+  echo "efi: ${efi_hash}"
+
+  popd >/dev/null
 
   if [ -n "${FLAGS_firmware_updater}" ]; then
     firmware_hash="$(compress_and_hash_file "${FLAGS_firmware_updater}" \