From aabca6c6a3069fc9804c20690a2dc2cf87b8482c Mon Sep 17 00:00:00 2001 From: Mike Frysinger Date: Wed, 4 Apr 2012 13:31:44 -0400 Subject: [PATCH] setup_board: quote flags var Now that the flags variable can be "[stable]", if we don't quote its expansion, it can match files like "t" resulting in bad flags being passed to crossdev. BUG=None TEST=`touch t; ./setup_board --board=x86-alex` no longer results in "tgcc" Change-Id: I866e934776e2d47a2c99bd08964017014aace97f Reviewed-on: https://gerrit.chromium.org/gerrit/19595 Reviewed-by: Zdenek Behan Commit-Ready: Mike Frysinger Tested-by: Mike Frysinger --- setup_board | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/setup_board b/setup_board index a524edfc2f..38b2765ea1 100755 --- a/setup_board +++ b/setup_board @@ -249,10 +249,10 @@ build_toolchain() { fi if [ $FLAGS_latest_toolchain -ne $FLAGS_TRUE ]; then CROSS_ARGS+=( - --binutils $FLAGS_binutils_version - --gcc $FLAGS_gcc_version - --kernel $FLAGS_kernel_version - --libc $FLAGS_libc_version + --binutils "${FLAGS_binutils_version}" + --gcc "${FLAGS_gcc_version}" + --kernel "${FLAGS_kernel_version}" + --libc "${FLAGS_libc_version}" ) fi CROSS_ARGS+=(