From a7056f1b071c7a8b2e9b392c0f6a140cdd9fbcec Mon Sep 17 00:00:00 2001 From: Michael Krebs Date: Tue, 24 Apr 2012 20:12:39 -0700 Subject: [PATCH] buildbot scripts: Increase number of retries for uploading Delay up to 63 seconds when trying to upload a symbol file. My default of 15 seconds before turned out to not be enough to cover at least one case that davidjames@ found in ToT buildbots. BUG=chromium-os:29963 TEST=Ran upload_symbols --testing Change-Id: I82b038f8845c3f2aaba0ee95f40efd4b70e2ffb1 Reviewed-on: https://gerrit.chromium.org/gerrit/21016 Commit-Ready: Michael Krebs Tested-by: Michael Krebs Reviewed-by: David James --- upload_symbols | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/upload_symbols b/upload_symbols index 77de602eac..b083ff08b8 100755 --- a/upload_symbols +++ b/upload_symbols @@ -33,8 +33,9 @@ DEFINE_boolean yes ${FLAGS_FALSE} "Answer yes to all prompts." # Number of seconds to wait before retrying an upload. The delay will double # for each subsequent retry of the same symbol file. INITIAL_RETRY_DELAY=1 -# Allow up to 5 attempts to upload a symbol file. -MAX_RETRIES=4 +# Allow up to 7 attempts to upload a symbol file (total delay may be +# 1+2+4+8+16+32=63 seconds). +MAX_RETRIES=6 # Number of total errors, ${TOTAL_ERROR_COUNT}, before retries are no longer # attempted. This is used to avoid lots of errors causing unreasonable delays. MAX_TOTAL_ERRORS_FOR_RETRY=3 # don't bother retrying after 3 errors