ci-automation: Apply suggestions from PR review

Co-authored-by: Krzesimir Nowak <knowak@microsoft.com>
This commit is contained in:
Thilo Fromm 2022-01-07 20:09:49 +01:00
parent 0ecd0be77a
commit a6ddcda88e
3 changed files with 5 additions and 5 deletions

View File

@ -142,13 +142,13 @@ get_board_binhost() {
board="$1" board="$1"
shift shift
local no_toolchain=0 local pkgs_include_toolchain=0
if [[ $# -eq 0 ]]; then if [[ $# -eq 0 ]]; then
if [[ "${FLATCAR_BUILD_ID}" =~ ^nightly-.*$ ]] ; then if [[ "${FLATCAR_BUILD_ID}" =~ ^nightly-.*$ ]] ; then
# containerised nightly build; this uses [VERSION]-[BUILD_ID] for binpkg url # containerised nightly build; this uses [VERSION]-[BUILD_ID] for binpkg url
# and toolchain packages are at the same location as OS image ones # and toolchain packages are at the same location as OS image ones
set -- "${FLATCAR_VERSION_ID}-${FLATCAR_BUILD_ID}" set -- "${FLATCAR_VERSION_ID}-${FLATCAR_BUILD_ID}"
no_toolchain=1 pkgs_include_toolchain=1
else else
set -- "${FLATCAR_VERSION_ID}" set -- "${FLATCAR_VERSION_ID}"
fi fi
@ -158,7 +158,7 @@ get_board_binhost() {
if [[ $toolchain_only -eq 0 ]]; then if [[ $toolchain_only -eq 0 ]]; then
echo "${FLATCAR_DEV_BUILDS}/boards/${board}/${ver}/pkgs/" echo "${FLATCAR_DEV_BUILDS}/boards/${board}/${ver}/pkgs/"
fi fi
if [[ $no_toolchain -eq 0 ]]; then if [[ $pkgs_include_toolchain -eq 0 ]]; then
echo "${FLATCAR_DEV_BUILDS}/boards/${board}/${ver}/toolchain/" echo "${FLATCAR_DEV_BUILDS}/boards/${board}/${ver}/toolchain/"
fi fi
done done

View File

@ -89,7 +89,7 @@ function garbage_collect() {
else else
echo "## ${version} is an OS image version. ##" echo "## ${version} is an OS image version. ##"
rmpat="${BUILDCACHE_PATH_PREFIX}/containers/${os_docker_vernum}/flatcar-packages-*" rmpat="${BUILDCACHE_PATH_PREFIX}/containers/${os_docker_vernum}/flatcar-packages-*"
rmpat="${BUILDCACHE_PATH_PREFIX}/binpkgs/boards/*/${os_docker_vernum}/*" rmpat="${rmpat} ${BUILDCACHE_PATH_PREFIX}/binpkgs/boards/*/${os_docker_vernum}/*"
rmpat="${rmpat} ${BUILDCACHE_PATH_PREFIX}/containers/${os_docker_vernum}/flatcar-images-*" rmpat="${rmpat} ${BUILDCACHE_PATH_PREFIX}/containers/${os_docker_vernum}/flatcar-images-*"
rmpat="${rmpat} ${BUILDCACHE_PATH_PREFIX}/images/*/${os_vernum}/" rmpat="${rmpat} ${BUILDCACHE_PATH_PREFIX}/images/*/${os_vernum}/"
fi fi

View File

@ -19,7 +19,7 @@
# 2. Scripts repo version tag of OS image version to be built is available and checked out. # 2. Scripts repo version tag of OS image version to be built is available and checked out.
# 3. Flatcar packages container is available via build cache server # 3. Flatcar packages container is available via build cache server
# from "/containers/[VERSION]/flatcar-packages-[ARCH]-[FLATCAR_VERSION].tar.gz" # from "/containers/[VERSION]/flatcar-packages-[ARCH]-[FLATCAR_VERSION].tar.gz"
# or present locally. Container must contain binary packages and torcx artefacts. # or present locally. Container must contain binary packages and torcx artifacts.
# #
# INPUT: # INPUT:
# #