mirror of
https://github.com/flatcar/scripts.git
synced 2025-09-23 06:31:18 +02:00
Apply suggestions from code review
Co-authored-by: Krzesimir Nowak <knowak@microsoft.com>
This commit is contained in:
parent
f66d24dec7
commit
83a85683c8
@ -147,7 +147,7 @@ function _garbage_collect_impl() {
|
|||||||
echo
|
echo
|
||||||
echo "########################################"
|
echo "########################################"
|
||||||
echo
|
echo
|
||||||
echo Running cloud garbace collector
|
echo Running cloud garbage collector
|
||||||
echo
|
echo
|
||||||
|
|
||||||
local mantle_ref
|
local mantle_ref
|
||||||
@ -165,7 +165,7 @@ function _garbage_collect_impl() {
|
|||||||
echo
|
echo
|
||||||
echo "#############################################"
|
echo "#############################################"
|
||||||
echo
|
echo
|
||||||
echo Running Github CI SDK garbace collector
|
echo Running Github CI SDK garbage collector
|
||||||
echo
|
echo
|
||||||
|
|
||||||
source ci-automation/garbage_collect_github_ci_sdk.sh
|
source ci-automation/garbage_collect_github_ci_sdk.sh
|
||||||
|
@ -55,9 +55,9 @@ function _garbage_collect_github_ci_impl() {
|
|||||||
echo "######## Full list of version(s) found ########"
|
echo "######## Full list of version(s) found ########"
|
||||||
echo "${versions_sorted}" | awk '{printf "%5d %s\n", NR, $0}'
|
echo "${versions_sorted}" | awk '{printf "%5d %s\n", NR, $0}'
|
||||||
|
|
||||||
local keep="$((keep + 1))" # for tail -n+...
|
keep="$((keep + 1))" # for tail -n+...
|
||||||
local purge_versions="$(echo "${versions_sorted}" \
|
local purge_versions
|
||||||
| tail -n+"${keep}")"
|
mapfile -t purge_versions < <(tail -n+"${keep}" <<<"${versions_sorted}")
|
||||||
|
|
||||||
source ci-automation/ci_automation_common.sh
|
source ci-automation/ci_automation_common.sh
|
||||||
local sshcmd="$(gen_sshcmd)"
|
local sshcmd="$(gen_sshcmd)"
|
||||||
@ -69,12 +69,12 @@ function _garbage_collect_github_ci_impl() {
|
|||||||
echo "(NOTE this is just a dry run since DRY_RUN=y)"
|
echo "(NOTE this is just a dry run since DRY_RUN=y)"
|
||||||
echo
|
echo
|
||||||
fi
|
fi
|
||||||
echo "${purge_versions}" | awk -v keep="${keep}" '{if ($0 == "") next; printf "%5d %s\n", NR + keep - 1, $0}'
|
printf '%s\n' "${purge_versions[@]}" | awk -v keep="${keep}" '{if ($0 == "") next; printf "%5d %s\n", NR + keep - 1, $0}'
|
||||||
echo
|
echo
|
||||||
echo
|
echo
|
||||||
|
|
||||||
local version=""
|
local version=""
|
||||||
for version in ${purge_versions}; do
|
for version in "${purge_versions[@]}"; do
|
||||||
echo "--------------------------------------------"
|
echo "--------------------------------------------"
|
||||||
echo
|
echo
|
||||||
echo "#### Processing version '${version}' ####"
|
echo "#### Processing version '${version}' ####"
|
||||||
|
Loading…
x
Reference in New Issue
Block a user