mirrors/flatcar-scripts
1
0
Fork 0
mirror of https://github.com/flatcar/scripts.git synced 2025-11-27 13:31:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

run_chroot_version_hooks: sanity check for multiple upgrades hooks

Browse Source 
If people land upgrade hooks of the same version levels independently and
no one notices, we get into an inconsistent state where only one of the
hooks actually runs.  Add a sanity check so we bail rather than upgrading
the chroot with an arbitrarily picked script.

BUG=None
TEST=run build_packages with multiple 17_xxx files in a ver 16 chroot and see script error out
TEST=run build_packages with single 17_xxx file in a ver 16 chroot and see successful run

Change-Id: If9a71f60badb7c9643c1a03ad49bb23ffb64f341
Reviewed-on: https://gerrit.chromium.org/gerrit/11972
Reviewed-by: Zdenek Behan <zbehan@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Mike Frysinger 2011-11-19 01:57:03 -05:00 committed by Gerrit
parent f331598aa9
commit 7cd3c285d2
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
run_chroot_version_hooks
View File

@ -110,17 +110,29 @@ if [ "${LATEST_VERSION}" -gt "${CHROOT_VERSION}" ]; then
pushd "${UPGRADE_D}" 1> /dev/null
for n in $(seq "$(expr ${CHROOT_VERSION} + 1)" "${LATEST_VERSION}"); do
hook=(${n}_*)
# Sanity check: if there are multiple ${n}_* files, then CL's landed
# at the same time and people didn't notice. Let's notice for them.
if [ ${#hook[@]} -gt 1 ]; then
error "Fatal: Upgrade ${n} has multiple hooks:"
error " ${hook[*]}"
error "Connor MacLeod knows: There can be only one."
exit 1
fi
hook=${hook[0]}
# Deprecation check; Deprecation can be done by removing old upgrade
# scripts and causing too old chroots to have to start over.
# Upgrades have to form a continuous sequence.
if ! [ -f ${n}_* ]; then
if ! [ -f ${hook} ]; then
error "Fatal: Upgrade ${n} doesn't exist."
error "Your chroot is so old, that some updates have been deprecated!"
error "You need to re-create it!"
exit 1
fi
info "Rollup $(echo ${n}_*)"
info "Rollup ${hook}"
# Attempt the upgrade.
# NOTE: We source the upgrade scripts because:
@ -129,7 +141,7 @@ if [ "${LATEST_VERSION}" -gt "${CHROOT_VERSION}" ]; then
# Side effect is that the scripts have to be internally enclosed in
# a code block, otherwise simply running "exit" in any of them would
# terminate the master script, so we call it in a subshell.
if ! ( source ${n}_* ); then
if ! ( source ${hook} ); then
error "Fatal: failed to upgrade ${n}!"
exit 1
fi