From 7bf8d2715edc720c64adccd5c08347bee1aa56b2 Mon Sep 17 00:00:00 2001 From: David James Date: Sat, 25 Sep 2010 23:23:00 -0700 Subject: [PATCH] Switch off repo sync --jobs, and turn on repo --trace. repo sync --jobs doesn't check for errors, so we shouldn't use it in automated scripts. repo --trace is needed so that we can diagnose whether git is hanging. BUG=chromium-os:7048, chromium-os:6774 TEST=Ran test suite Change-Id: I9e68cfffe841a231f5fabef951ea2d45b81c1d5e Review URL: http://codereview.chromium.org/3419024 --- bin/cbuildbot.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/bin/cbuildbot.py b/bin/cbuildbot.py index cd9a3a5beb..14e22d1042 100755 --- a/bin/cbuildbot.py +++ b/bin/cbuildbot.py @@ -47,13 +47,12 @@ def RepoSync(buildroot, rw_checkout=False, retries=_DEFAULT_RETRIES): retries -- Number of retries to try before failing on the sync. """ - # Get the number of processors to use with repo sync. - num_procs = int(RunCommand('grep -c processor /proc/cpuinfo'.split(), - print_cmd=False, redirect_stdout=True)) - while retries > 0: try: - RunCommand(['repo', 'sync', '--jobs=%d' % (num_procs)], cwd=buildroot) + # The --trace option ensures that repo shows the output from git. This + # is needed so that the buildbot can kill us if git is not making + # progress. + RunCommand(['repo', '--trace', 'sync'], cwd=buildroot) if rw_checkout: # Always re-run in case of new git repos or repo sync # failed in a previous run because of a forced Stop Build.