From 6f7d6cef0e68743625626b39a742c1616ee7b939 Mon Sep 17 00:00:00 2001 From: Chris Sosa Date: Thu, 26 Aug 2010 12:34:20 -0700 Subject: [PATCH] Fix case where there is nothing to uprev. TEST=Ran unit tests. Change-Id: Iafd9702c5364511d79667ecc296eaf68fc89a5fb Review URL: http://codereview.chromium.org/3159047 --- bin/cbuildbot.py | 3 +++ bin/cbuildbot_unittest.py | 1 + 2 files changed, 4 insertions(+) diff --git a/bin/cbuildbot.py b/bin/cbuildbot.py index 685443db7e..6bc398a665 100755 --- a/bin/cbuildbot.py +++ b/bin/cbuildbot.py @@ -209,6 +209,9 @@ def _ParseRevisionString(revision_string, repo_dictionary): def _UprevFromRevisionList(buildroot, revision_list): """Uprevs based on revision list.""" + if not revision_list: + print >> sys.stderr, 'No packages found to uprev' + return package_str = '' commit_str = '' for package, revision in revision_list: diff --git a/bin/cbuildbot_unittest.py b/bin/cbuildbot_unittest.py index c0f3c1c7cd..d3c0500fc2 100755 --- a/bin/cbuildbot_unittest.py +++ b/bin/cbuildbot_unittest.py @@ -29,6 +29,7 @@ class CBuildBotTest(mox.MoxTestBase): 'cros' : ['chromos-base/libcros'] } self._test_string = "kernel.git@12345test cros.git@12333test" + self._test_string += " crosutils.git@blahblah" self._revision_file = 'test-revisions.pfq' self._test_parsed_string_array = [ ['chromeos-base/kernel', '12345test'],