fix(test_image_content): Improve /usr symlink and conflict tests.

Now uses the package database instead of filesystem so the check works
even if /bin and friends are symlinks to /usr. Also disable the
whitelist and check that the expected symlinks are correct if the
symlink-usr USE flag is enabled.

build_library/test_build_root

@@ -12,6 +12,8 @@ SCRIPT_ROOT=$(readlink -f $(dirname "$0")/..)
 assert_inside_chroot
 
 # Flags
+DEFINE_string board "${DEFAULT_BOARD}" \
+  "The board name."
 DEFINE_string root "${DEFAULT_BOARD+/build/${DEFAULT_BOARD}}" \
   "The root file system to check."
 
@@ -26,4 +28,5 @@ if [[ ! -d "$FLAGS_root" ]]; then
   die_notrace "Root FS does not exist ($FLAGS_root)"
 fi
 
-test_image_content "$FLAGS_root"
+BOARD="${FLAGS_board}"
+test_image_content "$FLAGS_root" || die_notrace "Errors found!"

build_library/test_image_content.sh

@@ -37,6 +37,11 @@ test_image_content() {
   local root="$1"
   local returncode=0
 
+  if [[ -z "$BOARD" ]]; then
+    die '$BOARD is undefined!'
+  fi
+  local portageq="portageq-$BOARD"
+
   local binaries=(
     "$root/boot/vmlinuz"
     "$root/bin/sed"
@@ -86,28 +91,41 @@ test_image_content() {
     fi
   fi
 
-  # Check that there are no conflicts between /* and /usr/*
+  # Check that the symlink-usr flag agrees with the filesystem state.
-  # TODO(marineam): Before symlinking to /usr this test will need to be
+  # Things are likely to break if they don't match.
-  # rewritten to query the package database instead of the filesystem.
+  if [[ $(ROOT="${root}" $portageq envvar USE) == *symlink-usr* ]]; then
-  local check_dir
+    local dir
-  for check_dir in "${root}"/usr/*; do
+    for dir in bin sbin lib32 lib64; do
-    if [[ ! -d "${check_dir}" || -h "${check_dir}" ]]; then
+      if [[ -d "${root}/usr/${dir}" ]]; then
-      continue
+        if [[ ! -h "${root}/${dir}" || \
-    fi
+          $(readlink "${root}/${dir}") != "usr/${dir}" ]]
-    for check_file in "${check_dir}"/*; do
+        then
-      root_file="${root}${check_file##*/usr}"
+          error "test_image_content: /${dir} is not a symlink to /usr/${dir}"
-      trimmed_path="${root_file#${root}}"
+          returncode=1
-      local whitelist
-      for whitelist in "${USR_CONFLICT_WHITELIST[@]}"; do
-        if [[ "${trimmed_path}" == "${whitelist}" ]]; then
-          continue 2
         fi
-      done
-      if [[ -e "${root_file}" || -h "${root_file}" ]]; then
-        # TODO(marineam): make fatal before switching to symlinks
-        warn "test_image_content: ${root_file#${root}} conflicts with /usr"
       fi
     done
+
+    # The whitelist is only required if the use flag is unset
+    USR_CONFLICT_WHITELIST=()
+  fi
+
+  # Check that there are no conflicts between /* and /usr/*
+  local pkgdb=$(ROOT="${root}" $portageq vdb_path)
+  local files=$(awk '$2 ~ /^\/(bin|sbin|lib|lib32|lib64)\// {print $2}' \
+                "${pkgdb}"/*/*/CONTENTS)
+  local check_file
+  for check_file in $files; do
+    local whitelist
+    for whitelist in "${USR_CONFLICT_WHITELIST[@]}"; do
+      if [[ "${check_file}" == "${whitelist}" ]]; then
+        continue 2
+      fi
+    done
+    if grep -q "^... /usr$check_file " "${pkgdb}"/*/*/CONTENTS; then
+      error "test_image_content: $check_file conflicts with /usr$check_file"
+      returncode=1
+    fi
   done
 
   return $returncode