mirrors/flatcar-scripts
1
0
Fork 0
mirror of https://github.com/flatcar/scripts.git synced 2025-08-18 10:27:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

eclass: remove -Wl,-O1 from LDFLAGS passed to go_export

Browse Source 
Go 1.15.5 fixed a security issue CVE-2020-28366, by rejecting certain
LDFLAGS for CGO. See https://github.com/golang/go/issues/42559.

However, that change breaks builds based on the Flatcar build chain,
because `go_export` sets `$LDFLAGS` to `-Wl,-O1 -Wl,--as-needed`.
As a result, Go build fails like:

```
go build runtime/cgo: invalid flag in go:cgo_ldflag: -Wl,-O1
```

We need to remove the flag `-Wl,-O1` from $LDFLAGS before building the
Go runtime, to fix the failure.
This commit is contained in:
Dongsu Park 2020-11-13 09:45:21 +01:00
parent 72e72c2b3c
commit 5f7126329e
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sdk_container/src/third_party/coreos-overlay/eclass/coreos-go-utils.eclass vendored
View File

@ -84,6 +84,11 @@ go_export() {
append-ldflags -nopie
fi
# Remove certain flags from $LDFLAGS to fix validation errors in
# Go >= 1.15.5 like:
# go build runtime/cgo: invalid flag in go:cgo_ldflag: -Wl,-O1
filter-ldflags "-Wl,-O1"
export CC=$(tc-getCC)
export CXX=$(tc-getCXX)
export CGO_ENABLED=${CGO_ENABLED:-1}