From 5a881e22498550c40f7e03c31084d3d81f23b9f0 Mon Sep 17 00:00:00 2001 From: Darin Petkov Date: Fri, 12 Mar 2010 09:55:00 -0800 Subject: [PATCH] Fail build_autotest.sh if any test fails to build. This change may be controversial -- it will basically make the x86-generic full buildbot fail if tests fail to build. There are a few options: 1. do this and see how it goes; 2. don't do this and rely on the test failing to run; 3. do this but also change buildbot to pass --nobuildcheck to build_autotest Review URL: http://codereview.chromium.org/848005 --- build_autotest.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build_autotest.sh b/build_autotest.sh index 3adf2920ac..acb610a969 100755 --- a/build_autotest.sh +++ b/build_autotest.sh @@ -23,7 +23,7 @@ DEFINE_string build "${DEFAULT_TESTS_LIST}" \ "a comma seperated list of autotest client tests to be prebuilt." b DEFINE_boolean prompt $FLAGS_TRUE "Prompt user when building all tests." DEFINE_boolean autox $FLAGS_TRUE "Build autox along with autotest" -DEFINE_boolean buildcheck $FLAGS_FALSE "Fail if tests fail to build" +DEFINE_boolean buildcheck $FLAGS_TRUE "Fail if tests fail to build" # More useful help FLAGS_HELP="usage: $0 [flags]"