Merge pull request #261 from marineam/coreception

Fixes for SDK setup

sdk_lib/enter_chroot.sh

@@ -85,6 +85,8 @@ FILES_TO_COPY_TO_CHROOT=(
   .netrc                      # May contain required source fetching credentials
   .boto                       # Auth information for gsutil
   .boto-key.p12               # Service account key for gsutil
+  .ssh/config                 # User may need this for fetching git over ssh
+  .ssh/known_hosts            # Reuse existing known hosts
 )
 
 INNER_CHROME_ROOT=$FLAGS_chrome_root_mount  # inside chroot
@@ -128,41 +130,6 @@ setup_mount() {
   esac
 }
 
-copy_ssh_config() {
-  # Copy user .ssh/config into the chroot filtering out strings not supported
-  # by the chroot ssh. The chroot .ssh directory is passed in as the first
-  # parameter.
-
-  # ssh options to filter out. The entire strings containing these substrings
-  # will be deleted before copying.
-  local bad_options=(
-    'UseProxyIf'
-    'GSSAPIAuthentication'
-    'GSSAPIKeyExchange'
-    'ProxyUseFdpass'
-  )
-  local sshc="${SUDO_HOME}/.ssh/config"
-  local chroot_ssh_dir="${1}"
-  local filter
-  local option
-
-  if ! user_cp "${sshc}" "${chroot_ssh_dir}/config.orig" 2>/dev/null; then
-    return # Nothing to copy.
-  fi
-
-  for option in "${bad_options[@]}"
-  do
-    if [ -z "${filter}" ]; then
-      filter="${option}"
-    else
-      filter+="\\|${option}"
-    fi
-  done
-
-  sed "/^.*\(${filter}\).*$/d" "${chroot_ssh_dir}/config.orig" | \
-    user_clobber "${chroot_ssh_dir}/config"
-}
-
 copy_into_chroot_if_exists() {
   # $1 is file path outside of chroot to copy to path $2 inside chroot.
   [ -e "$1" ] && cp -p "$1" "${FLAGS_chroot}/$2"
@@ -236,9 +203,13 @@ setup_env() {
     # Make the lockfile writable for backwards compatibility.
     chown ${SUDO_UID}:${SUDO_GID} "${LOCKFILE}"
 
-    # Refresh /etc/resolv.conf and /etc/hosts in the chroot.
-    install -C -m644 /etc/resolv.conf ${FLAGS_chroot}/etc/resolv.conf
-    install -C -m644 /etc/hosts ${FLAGS_chroot}/etc/hosts
+    # Refresh system config files in the chroot.
+    for copy_file in /etc/{hosts,localtime,resolv.conf}; do
+      if [ -f "${copy_file}" ] ; then
+        rm -f "${FLAGS_chroot}${copy_file}"
+        install -C -m644 "${copy_file}" "${FLAGS_chroot}${copy_file}"
+      fi
+    done
 
     debug "Mounting chroot environment."
     MOUNT_CACHE=$(echo $(awk '{print $2}' /proc/mounts))
@@ -252,12 +223,12 @@ setup_env() {
     setup_mount none "-t sysfs" /sys
     setup_mount /dev "--bind" /dev
     setup_mount /dev/pts "--bind" /dev/pts
-    if [[ -d /run ]]; then
-      setup_mount /run "--bind" /run
+    setup_mount tmpfs "-t tmpfs -o nosuid,nodev,mode=755" /run
     if [[ -d /run/shm && ! -L /run/shm ]]; then
       setup_mount /run/shm "--bind" /run/shm
     fi
-    fi
+    mkdir -p /run/user/${SUDO_UID}
+    chown ${SUDO_UID}:${SUDO_GID} /run/user/${SUDO_UID}
 
     # Do this early as it's slow and only needs basic mounts (above).
     generate_locales &
@@ -330,25 +301,12 @@ setup_env() {
       chmod 0644 "${p}"
     fi
 
+    user_mkdir "${FLAGS_chroot}/home/${SUDO_USER}/.ssh"
     if [ $FLAGS_ssh_agent -eq $FLAGS_TRUE ]; then
       # Clean up previous ssh agents.
       rmdir "${FLAGS_chroot}"/tmp/ssh-* 2>/dev/null
 
       if [ -n "${SSH_AUTH_SOCK}" -a -d "${SUDO_HOME}/.ssh" ]; then
-        TARGET_DIR="${FLAGS_chroot}/home/${SUDO_USER}/.ssh"
-        user_mkdir "${TARGET_DIR}"
-        (
-          # Only copy ~/.ssh/{known_hosts,*.pub} if they exist. Since we set
-          # nullglob, this needs to happen within a subshell.
-          shopt -s nullglob
-          files=("${SUDO_HOME}"/.ssh/{known_hosts,*.pub})
-          if [[ ${#files[@]} -gt 0 ]]; then
-            user_cp "${files[@]}" "${TARGET_DIR}/"
-          fi
-        )
-        copy_ssh_config "${TARGET_DIR}"
-        chown -R ${SUDO_UID}:${SUDO_GID} "${TARGET_DIR}"
-
         # Don't try to bind mount the ssh agent dir if it has gone stale.
         ASOCK=${SSH_AUTH_SOCK%/*}
         if [ -d "${ASOCK}" ]; then

sdk_lib/make_chroot.sh

@@ -182,19 +182,6 @@ EOF
    # Fix bad group for some.
    chown -R root:root "${FLAGS_chroot}/etc/"sudoers*
 
-   info "Setting timezone..."
-   rm -f "${FLAGS_chroot}/etc/localtime"
-   if [ -f /etc/localtime ] ; then
-     cp /etc/localtime "${FLAGS_chroot}/etc"
-   else
-     ln -sf /usr/share/zoneinfo/UTC "${FLAGS_chroot}/etc/localtime"
-   fi
-
-   info "Setting up hosts/resolv..."
-   # Copy config from outside chroot into chroot.
-   cp /etc/{hosts,resolv.conf} "$FLAGS_chroot/etc/"
-   chmod 0644 "$FLAGS_chroot"/etc/{hosts,resolv.conf}
-
    # Create directories referred to by our conf files.
    mkdir -p -m 775 "${FLAGS_chroot}/var/lib/portage/pkgs" \
      "${FLAGS_chroot}/var/cache/"chromeos-{cache,chrome} \