From 43bbabec4bcdd07f42220c685886a669593cff65 Mon Sep 17 00:00:00 2001
From: Thilo Fromm <thilofromm@microsoft.com>
Date: Mon, 27 Mar 2023 09:35:05 +0200
Subject: [PATCH] ci.yaml: extract + upload build logs also on failure

Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
---
 .github/workflows/ci.yaml | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 06f17bb054..0a27cf1a6d 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -151,6 +151,7 @@ jobs:
           sdk_image="$(docker_image_fullname "${sdk_name}" "${docker_sdk_vernum}")"
 
           container_name="flatcar-ci-build"
+          echo "container_name=${container_name}" >> "$GITHUB_ENV"
 
           # Create version file
           (
@@ -166,19 +167,24 @@ jobs:
                 --torcx_output_root="${CI_CONTAINER_TORCX_ROOT}" \
                 --torcx_extra_pkg_url="${TORCX_TESTS_PACKAGE_URL}"
 
-          # Copy logs
-          ./run_sdk_container -n "${container_name}" \
-              tar -cJf ebuild_logs.tar.xz /build/${arch}-usr/var/log/portage \
-              /build/${arch}-usr/var/tmp/portage
-
           # Create binpkgs tarball for archiving as artifact later
           ./run_sdk_container -n "${container_name}" \
               tar -C "/build/${arch}-usr/var/lib/portage/pkgs/" \
                 -cvf binpkgs.tar .
 
-          echo "container_name=${container_name}" >> "$GITHUB_ENV"
+      - name: Extract build logs
+        if: always()
+        shell: bash
+        run: |
+          set -euo pipefail
+          set -x
+          # Copy logs
+          ./run_sdk_container -n "${container_name}" \
+              tar -cJf ebuild_logs.tar.xz /build/${arch}-usr/var/log/portage \
+              /build/${arch}-usr/var/tmp/portage
 
       - name: Upload build logs
+        if: always()
         uses: actions/upload-artifact@v3
         with:
           retention-days: 7