From 16e4cb4e20b137f78aeb586b970ebde981b26e9d Mon Sep 17 00:00:00 2001 From: Kai Lueke Date: Fri, 28 Oct 2022 15:35:57 +0200 Subject: [PATCH] vm_image_util: Use qemu-img for streamOptimized VMDKs To create the streamOptimized VMDK format we use the vmdk-convert utility. Nowadays qemu-img can also create this format directly, for supported formats see: https://www.qemu.org/docs/master/system/qemu-block-drivers.html --- build_library/vm_image_util.sh | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/build_library/vm_image_util.sh b/build_library/vm_image_util.sh index ac7e65d89b..e195ed9afb 100644 --- a/build_library/vm_image_util.sh +++ b/build_library/vm_image_util.sh @@ -587,12 +587,7 @@ _write_hdd_disk() { } _write_vmdk_stream_disk() { - # requires two pass conversion, qemu-img doesn't properly support the - # stream-optimized VMDK format. The special vmdk-convert tool only takes - # VMDK images as an import format. - local tmpvmdk="${VM_TMP_DIR}/tmp.vmdk" - qemu-img convert -f raw "$1" -O vmdk -o adapter_type=lsilogic "${tmpvmdk}" - vmdk-convert "${tmpvmdk}" "$2" + qemu-img convert -f raw "$1" -O vmdk -o subformat=streamOptimized,adapter_type=lsilogic "$2" assert_image_size "$2" vmdk }