Merge pull request #846 from flatcar/t-lo/fix-pr-test-results-comment

workflows/pr-comment,run-kola: fix concurrency + results comment
This commit is contained in:
Thilo Fromm 2023-05-31 09:23:29 +02:00 committed by GitHub
commit 0a8f4a54a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 7 deletions

View File

@ -7,7 +7,7 @@ permissions:
pull-requests: write
concurrency:
group: ${{ github.workflow }}-pr-command-${{ github.head_ref || github.ref_name }}
group: ${{ github.workflow }}-pr-command-${{ github.event.issue.pull_request.number }}
cancel-in-progress: true
jobs:
@ -49,9 +49,15 @@ jobs:
$res
- name: Post a link to the workflow run to the PR
uses: mshick/add-pr-comment@v2
with:
issue: ${{ github.event.issue.pull_request.number }}
message: "Build action triggered: [${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})"
update_sdk:
needs: check_maintainer_membership
if: ( always() && needs.check_maintainer_membership.result == 'success'
if: ( needs.check_maintainer_membership.result == 'success'
&& contains(github.event.comment.body, '/update-sdk') )
name: "Build an updated SDK container"
# SDK build needs access to bincache ssh secret
@ -60,7 +66,7 @@ jobs:
build_image:
needs: [ check_maintainer_membership, update_sdk ]
if: ( always() && needs.check_maintainer_membership.result == 'success'
if: ( needs.check_maintainer_membership.result == 'success'
&& ( contains(github.event.comment.body, '/build-image') || needs.update_sdk.result == 'success' ) )
name: "Build the OS image"
uses: ./.github/workflows/ci.yaml

View File

@ -351,8 +351,9 @@ jobs:
cat test-results.md >> "$GITHUB_STEP_SUMMARY"
- name: If started from a PR, post test summary to PR
if: ${{ github.event_name == 'pull_request' }}
- name: If started from a PR event or a PR comment command, post test summary to PR
if: ${{ github.event_name == 'pull_request' || github.event.issue.pull_request }}
uses: mshick/add-pr-comment@v2
with:
issue: ${{ github.event.pull_request.number || github.event.issue.pull_request.number }}
message-path: "scripts/test-results.md"