From 05780783a936c39fc271ba71f0afec3601b8e837 Mon Sep 17 00:00:00 2001 From: Zdenek Behan Date: Fri, 18 May 2012 03:07:28 +0200 Subject: [PATCH] crosutils: disallow running build_packages/setup_board as root Running these as root does not make sense. Furthermore, it will fail on calling cros-workon, which sometimes fails but most certainly will not give correct information anyway. BUG=chromium-os:30384 TEST=run build_packages/setup_board with/without sudo Change-Id: I0cba72334369e35ba0e864c53fd81037ee9e0efa Reviewed-on: https://gerrit.chromium.org/gerrit/23003 Reviewed-by: Mike Frysinger Commit-Ready: Zdenek Behan Tested-by: Zdenek Behan --- build_packages | 2 ++ setup_board | 2 ++ 2 files changed, 4 insertions(+) diff --git a/build_packages b/build_packages index 3256d91390..1d0bfe987c 100755 --- a/build_packages +++ b/build_packages @@ -11,6 +11,8 @@ restart_in_chroot_if_needed "$@" get_default_board +assert_not_root_user + # Developer-visible flags. DEFINE_string board "${DEFAULT_BOARD}" \ "The board to build packages for." diff --git a/setup_board b/setup_board index 0d7d2cc6d4..fc011ff1a7 100755 --- a/setup_board +++ b/setup_board @@ -12,6 +12,8 @@ restart_in_chroot_if_needed "$@" get_default_board +assert_not_root_user + # Developer-visible flags. DEFINE_string board "$DEFAULT_BOARD" \ "The name of the board to set up."