mirror of
https://github.com/kubernetes-sigs/external-dns.git
synced 2025-10-14 11:21:01 +02:00
5d54849699
* Endpoint.Target is now Endpoint.Targets. This is its own type representing mutliple targets for a single DNS name while adding some convenience for sorting and comparing * Made everything compile and tests run through with the new Endpoint.Targets * The ingress source can now properly handle multiple target ips per host * Added custom conflict resolver, to better understand how conflict resolution has to work for me * My custom conflict resolver behaves a bit different than the PerResource resolver, therefore I needed to modify the expected test result Removed unnecessary FIXME * The ingress source now creates CNAME endpoints with multiple targets to let the DNS provider decide how to handle multiple CNAME targets. This could be interesting for weighted targets etc. * Adopted the expected results to the new way we create endpoints for CNAMEs * Removed Add method from Targets since manipulating the slice through here is unnecessary complicated and doesn't deliver enough convenience * Reverted ConflictResolver to the original one. There is some discussing to do what the best way is to handle conflicts * Added missing documenting comment to IsLess of Targets * Added documenting comments to Targets,Targets.Same and NewTargets to clarify their intention and usage * Service source now also generates endpoints with multiple targets * Service and Ingress source now sort all Targets for every Endpoint to make order of Targets predictable * Endpoints generated by the Google Cloud DNS provider now also have sorted Targets to make order of Targets predictable * Modified provider dyn to be able to compile with multi target changes * Fixed small nitpicks, so my code is acceptable * Fixed merge method after updating to new Targets. Replacing '!=' with .Same of course needs a boolean negation * Tests for dyn provider now also use the new Targets instead of Target * Simplified extractServiceIps as implied by linki to make it more readable * ref: change service ClusterIP retrieval again * Added entry to CHANGELOG.md describing the new features contained in this PR
82 lines
2.7 KiB
Go
82 lines
2.7 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package plan
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/kubernetes-incubator/external-dns/endpoint"
|
|
)
|
|
|
|
// TestApply tests that applying a policy results in the correct set of changes.
|
|
func TestApply(t *testing.T) {
|
|
// empty list of records
|
|
empty := []*endpoint.Endpoint{}
|
|
// a simple entry
|
|
fooV1 := []*endpoint.Endpoint{{DNSName: "foo", Targets: endpoint.Targets{"v1"}}}
|
|
// the same entry but with different target
|
|
fooV2 := []*endpoint.Endpoint{{DNSName: "foo", Targets: endpoint.Targets{"v2"}}}
|
|
// another two simple entries
|
|
bar := []*endpoint.Endpoint{{DNSName: "bar", Targets: endpoint.Targets{"v1"}}}
|
|
baz := []*endpoint.Endpoint{{DNSName: "baz", Targets: endpoint.Targets{"v1"}}}
|
|
|
|
for _, tc := range []struct {
|
|
policy Policy
|
|
changes *Changes
|
|
expected *Changes
|
|
}{
|
|
{
|
|
// SyncPolicy doesn't modify the set of changes.
|
|
&SyncPolicy{},
|
|
&Changes{Create: baz, UpdateOld: fooV1, UpdateNew: fooV2, Delete: bar},
|
|
&Changes{Create: baz, UpdateOld: fooV1, UpdateNew: fooV2, Delete: bar},
|
|
},
|
|
{
|
|
// UpsertOnlyPolicy clears the list of deletions.
|
|
&UpsertOnlyPolicy{},
|
|
&Changes{Create: baz, UpdateOld: fooV1, UpdateNew: fooV2, Delete: bar},
|
|
&Changes{Create: baz, UpdateOld: fooV1, UpdateNew: fooV2, Delete: empty},
|
|
},
|
|
} {
|
|
// apply policy
|
|
changes := tc.policy.Apply(tc.changes)
|
|
|
|
// validate changes after applying policy
|
|
validateEntries(t, changes.Create, tc.expected.Create)
|
|
validateEntries(t, changes.UpdateOld, tc.expected.UpdateOld)
|
|
validateEntries(t, changes.UpdateNew, tc.expected.UpdateNew)
|
|
validateEntries(t, changes.Delete, tc.expected.Delete)
|
|
}
|
|
}
|
|
|
|
// TestPolicies tests that policies are correctly registered.
|
|
func TestPolicies(t *testing.T) {
|
|
validatePolicy(t, Policies["sync"], &SyncPolicy{})
|
|
validatePolicy(t, Policies["upsert-only"], &UpsertOnlyPolicy{})
|
|
}
|
|
|
|
// validatePolicy validates that a given policy is of the given type.
|
|
func validatePolicy(t *testing.T, policy, expected Policy) {
|
|
policyType := reflect.TypeOf(policy).String()
|
|
expectedType := reflect.TypeOf(expected).String()
|
|
|
|
if policyType != expectedType {
|
|
t.Errorf("expected %q to match %q", policyType, expectedType)
|
|
}
|
|
}
|