mirror of
https://github.com/kubernetes-sigs/external-dns.git
synced 2025-09-20 15:41:01 +02:00
c6ed951abf
* fix(txt-registry): skip creation of already-existing TXT records (#4914) * refactor(registry): store existing TXT records temporarily between Records and ApplyChanges * refactor: apply review suggestion for code cleanup * test: add coverage for recreating A/CNAME records when TXT exists * refactor: extract generateTXTRecordWithFilter to avoid redundant filtering * test: add comprehensive test cases and isolate test data for t.Parallel * docs: clarify comment for isNotManaged to reflect actual behavior * fix: apply SetIdentifier before filtering TXT records, add regression test * chore: fix lint warnings * refactor: use key struct instead of concatenated string for map keys to reduce memory usage * fix txt_test.go * fix txt_test.go dependency * refactor(registry/txt): rename to isAbsent
94 lines
2.9 KiB
Go
94 lines
2.9 KiB
Go
/*
|
|
Copyright 2025 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package registry
|
|
|
|
import (
|
|
"sigs.k8s.io/external-dns/endpoint"
|
|
)
|
|
|
|
func newEndpointWithOwner(dnsName, target, recordType, ownerID string) *endpoint.Endpoint {
|
|
return newEndpointWithOwnerAndLabels(dnsName, target, recordType, ownerID, nil)
|
|
}
|
|
|
|
func newEndpointWithOwnerAndOwnedRecord(dnsName, target, recordType, ownerID, ownedRecord string) *endpoint.Endpoint {
|
|
return newEndpointWithOwnerAndLabels(dnsName, target, recordType, ownerID, endpoint.Labels{endpoint.OwnedRecordLabelKey: ownedRecord})
|
|
}
|
|
|
|
func newEndpointWithOwnerAndLabels(dnsName, target, recordType, ownerID string, labels endpoint.Labels) *endpoint.Endpoint {
|
|
e := endpoint.NewEndpoint(dnsName, recordType, target)
|
|
e.Labels[endpoint.OwnerLabelKey] = ownerID
|
|
for k, v := range labels {
|
|
e.Labels[k] = v
|
|
}
|
|
return e
|
|
}
|
|
|
|
func newEndpointWithOwnerResource(dnsName, target, recordType, ownerID, resource string) *endpoint.Endpoint {
|
|
e := endpoint.NewEndpoint(dnsName, recordType, target)
|
|
e.Labels[endpoint.OwnerLabelKey] = ownerID
|
|
e.Labels[endpoint.ResourceLabelKey] = resource
|
|
return e
|
|
}
|
|
|
|
// This is primarily used to prevent data races when running tests in parallel (t.Parallel).
|
|
func cloneEndpointsWithOpts(list []*endpoint.Endpoint, opt ...func(*endpoint.Endpoint)) []*endpoint.Endpoint {
|
|
cloned := make([]*endpoint.Endpoint, len(list))
|
|
for i, e := range list {
|
|
cloned[i] = cloneEndpointWithOpts(e, opt...)
|
|
}
|
|
return cloned
|
|
}
|
|
|
|
func cloneEndpointWithOpts(e *endpoint.Endpoint, opt ...func(*endpoint.Endpoint)) *endpoint.Endpoint {
|
|
targets := make(endpoint.Targets, len(e.Targets))
|
|
copy(targets, e.Targets)
|
|
|
|
// SameEndpoints treats nil and empty maps/slices as different.
|
|
// To avoid introducing unintended differences, we retain nil when original is nil.
|
|
var labels endpoint.Labels
|
|
if e.Labels != nil {
|
|
labels = make(endpoint.Labels, len(e.Labels))
|
|
for k, v := range e.Labels {
|
|
labels[k] = v
|
|
}
|
|
}
|
|
|
|
var providerSpecific endpoint.ProviderSpecific
|
|
if e.ProviderSpecific != nil {
|
|
providerSpecific = make(endpoint.ProviderSpecific, len(e.ProviderSpecific))
|
|
for i, p := range e.ProviderSpecific {
|
|
providerSpecific[i] = p
|
|
}
|
|
}
|
|
|
|
ttl := e.RecordTTL
|
|
|
|
ep := &endpoint.Endpoint{
|
|
DNSName: e.DNSName,
|
|
Targets: targets,
|
|
RecordType: e.RecordType,
|
|
RecordTTL: ttl,
|
|
Labels: labels,
|
|
ProviderSpecific: providerSpecific,
|
|
SetIdentifier: e.SetIdentifier,
|
|
}
|
|
for _, o := range opt {
|
|
o(ep)
|
|
}
|
|
return ep
|
|
}
|