external-dns/source/service_test.go
Martin Linkhorst b0f437a438 support hostnames as endpoint targets (CNAME support) (#122)
* feat(aws): support hostnames as endpoint targets

* docs: describe how to run ExternalDNS on AWS

* docs: update changelog with CNAME feature

* docs: update changelog to include AWS documentation

* fix(aws): test that updating records removes the old value

* feat(google): add CNAME support to Google provider

* fix(source): sanitize source and target hostnames

* docs: update changelog to include latest changes

* docs(aws): mention that ExternalDNS takes full ownership of a hosted zone

* fix(aws): switch route53 tests to use endpoint pointers

* docs: add TODO to remove record filtering once ownership is in place
2017-04-05 14:58:10 +02:00

266 lines
6.1 KiB
Go

/*
Copyright 2017 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package source
import (
"net"
"testing"
"k8s.io/client-go/kubernetes/fake"
"k8s.io/client-go/pkg/api/v1"
"github.com/kubernetes-incubator/external-dns/endpoint"
)
// Validates that serviceSource is a Source
var _ Source = &serviceSource{}
func TestService(t *testing.T) {
t.Run("Endpoints", testServiceEndpoints)
}
// testServiceEndpoints tests that various services generate the correct endpoints.
func testServiceEndpoints(t *testing.T) {
for _, tc := range []struct {
title string
targetNamespace string
svcNamespace string
svcName string
annotations map[string]string
lbs []string
expected []*endpoint.Endpoint
}{
{
"no annotated services return no endpoints",
"",
"testing",
"foo",
map[string]string{},
[]string{"1.2.3.4"},
[]*endpoint.Endpoint{},
},
{
"annotated services return an endpoint with target IP",
"",
"testing",
"foo",
map[string]string{
hostnameAnnotationKey: "foo.example.org.",
},
[]string{"1.2.3.4"},
[]*endpoint.Endpoint{
{DNSName: "foo.example.org.", Target: "1.2.3.4"},
},
},
{
"annotated services return an endpoint with target hostname",
"",
"testing",
"foo",
map[string]string{
hostnameAnnotationKey: "foo.example.org.",
},
[]string{"lb.example.com"}, // Kubernetes omits the trailing dot
[]*endpoint.Endpoint{
{DNSName: "foo.example.org.", Target: "lb.example.com."},
},
},
{
"annotated services can omit trailing dot",
"",
"testing",
"foo",
map[string]string{
hostnameAnnotationKey: "foo.example.org", // Trailing dot is omitted
},
[]string{"1.2.3.4", "lb.example.com"}, // Kubernetes omits the trailing dot
[]*endpoint.Endpoint{
{DNSName: "foo.example.org.", Target: "1.2.3.4"},
{DNSName: "foo.example.org.", Target: "lb.example.com."},
},
},
{
"our controller type is dns-controller",
"",
"testing",
"foo",
map[string]string{
controllerAnnotationKey: controllerAnnotationValue,
hostnameAnnotationKey: "foo.example.org.",
},
[]string{"1.2.3.4"},
[]*endpoint.Endpoint{
{DNSName: "foo.example.org.", Target: "1.2.3.4"},
},
},
{
"different controller types are ignored",
"",
"testing",
"foo",
map[string]string{
controllerAnnotationKey: "some-other-tool",
hostnameAnnotationKey: "foo.example.org.",
},
[]string{"1.2.3.4"},
[]*endpoint.Endpoint{},
},
{
"services are found in target namespace",
"testing",
"testing",
"foo",
map[string]string{
hostnameAnnotationKey: "foo.example.org.",
},
[]string{"1.2.3.4"},
[]*endpoint.Endpoint{
{DNSName: "foo.example.org.", Target: "1.2.3.4"},
},
},
{
"services that are not in target namespace are ignored",
"testing",
"other-testing",
"foo",
map[string]string{
hostnameAnnotationKey: "foo.example.org.",
},
[]string{"1.2.3.4"},
[]*endpoint.Endpoint{},
},
{
"services are found in all namespaces",
"",
"other-testing",
"foo",
map[string]string{
hostnameAnnotationKey: "foo.example.org.",
},
[]string{"1.2.3.4"},
[]*endpoint.Endpoint{
{DNSName: "foo.example.org.", Target: "1.2.3.4"},
},
},
{
"no external entrypoints return no endpoints",
"",
"testing",
"foo",
map[string]string{
hostnameAnnotationKey: "foo.example.org.",
},
[]string{},
[]*endpoint.Endpoint{},
},
{
"multiple external entrypoints return multiple endpoints",
"",
"testing",
"foo",
map[string]string{
hostnameAnnotationKey: "foo.example.org.",
},
[]string{"1.2.3.4", "8.8.8.8"},
[]*endpoint.Endpoint{
{DNSName: "foo.example.org.", Target: "1.2.3.4"},
{DNSName: "foo.example.org.", Target: "8.8.8.8"},
},
},
} {
t.Run(tc.title, func(t *testing.T) {
// Create a Kubernetes testing client
kubernetes := fake.NewSimpleClientset()
// Create a service to test against
ingresses := []v1.LoadBalancerIngress{}
for _, lb := range tc.lbs {
if net.ParseIP(lb) != nil {
ingresses = append(ingresses, v1.LoadBalancerIngress{IP: lb})
} else {
ingresses = append(ingresses, v1.LoadBalancerIngress{Hostname: lb})
}
}
service := &v1.Service{
ObjectMeta: v1.ObjectMeta{
Namespace: tc.svcNamespace,
Name: tc.svcName,
Annotations: tc.annotations,
},
Status: v1.ServiceStatus{
LoadBalancer: v1.LoadBalancerStatus{
Ingress: ingresses,
},
},
}
_, err := kubernetes.CoreV1().Services(service.Namespace).Create(service)
if err != nil {
t.Fatal(err)
}
// Create our object under test and get the endpoints.
client := NewServiceSource(kubernetes, tc.targetNamespace)
endpoints, err := client.Endpoints()
if err != nil {
t.Fatal(err)
}
// Validate returned endpoints against desired endpoints.
validateEndpoints(t, endpoints, tc.expected)
})
}
}
func BenchmarkServiceEndpoints(b *testing.B) {
kubernetes := fake.NewSimpleClientset()
service := &v1.Service{
ObjectMeta: v1.ObjectMeta{
Namespace: "testing",
Name: "foo",
Annotations: map[string]string{
hostnameAnnotationKey: "foo.example.org.",
},
},
Status: v1.ServiceStatus{
LoadBalancer: v1.LoadBalancerStatus{
Ingress: []v1.LoadBalancerIngress{
{IP: "1.2.3.4"},
{IP: "8.8.8.8"},
},
},
},
}
_, err := kubernetes.CoreV1().Services(service.Namespace).Create(service)
if err != nil {
b.Fatal(err)
}
client := NewServiceSource(kubernetes, v1.NamespaceAll)
for i := 0; i < b.N; i++ {
_, err := client.Endpoints()
if err != nil {
b.Fatal(err)
}
}
}