mirror of
https://github.com/kubernetes-sigs/external-dns.git
synced 2025-08-06 01:26:59 +02:00
* kickoff txt registry * fix inmemory dns provider to include recordtype info for validation * Merge master * fix ununsed variable in inmemory provider * add tests for records * add test for no prefix name formatter * implement apply changes with tests * add flag to enable txt registry * add txt registry to main * improve sort testing * filter out non-owned records * NewEndpoint(...) requires record type * use newendpoint in aws_test, fix tests * change suitable type implementation * fix the test for compatibility component * change inmemory provider to include recordtype and use suitable type * fix comments, CNAME should target hostname * name mapper do not use pointer on struct * txt prefix - just concatenate, remove spew, fix txt record label * allow TXT records as result from dns provider * add changelog * fix tests * TXT records need to be enclosed in double quotes
153 lines
3.4 KiB
Go
153 lines
3.4 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package registry
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/kubernetes-incubator/external-dns/endpoint"
|
|
"github.com/kubernetes-incubator/external-dns/internal/testutils"
|
|
"github.com/kubernetes-incubator/external-dns/plan"
|
|
"github.com/kubernetes-incubator/external-dns/provider"
|
|
)
|
|
|
|
var _ Registry = &NoopRegistry{}
|
|
|
|
func TestNoopRegistry(t *testing.T) {
|
|
t.Run("NewNoopRegistry", testNoopInit)
|
|
t.Run("Records", testNoopRecords)
|
|
t.Run("ApplyChanges", testNoopApplyChanges)
|
|
}
|
|
|
|
func testNoopInit(t *testing.T) {
|
|
p := provider.NewInMemoryProvider()
|
|
r, err := NewNoopRegistry(p)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if r.provider != p {
|
|
t.Error("noop registry incorrectly initialized")
|
|
}
|
|
}
|
|
|
|
func testNoopRecords(t *testing.T) {
|
|
p := provider.NewInMemoryProvider()
|
|
p.CreateZone("zone")
|
|
providerRecords := []*endpoint.Endpoint{
|
|
{
|
|
DNSName: "example.org",
|
|
Target: "example-lb.com",
|
|
},
|
|
}
|
|
p.ApplyChanges("zone", &plan.Changes{
|
|
Create: providerRecords,
|
|
})
|
|
|
|
r, _ := NewNoopRegistry(p)
|
|
_, err := r.Records("wrong-zone")
|
|
if err == nil {
|
|
t.Error("Should fail for wrong zone: wrong-zone")
|
|
}
|
|
|
|
r, _ = NewNoopRegistry(p)
|
|
eps, err := r.Records("zone")
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
if !testutils.SameEndpoints(eps, providerRecords) {
|
|
t.Error("incorrect result is returned")
|
|
}
|
|
}
|
|
|
|
func testNoopApplyChanges(t *testing.T) {
|
|
// do some prep
|
|
p := provider.NewInMemoryProvider()
|
|
p.CreateZone("zone")
|
|
providerRecords := []*endpoint.Endpoint{
|
|
{
|
|
DNSName: "example.org",
|
|
Target: "old-lb.com",
|
|
},
|
|
}
|
|
expectedUpdate := []*endpoint.Endpoint{
|
|
{
|
|
DNSName: "example.org",
|
|
Target: "new-example-lb.com",
|
|
RecordType: "CNAME",
|
|
},
|
|
{
|
|
DNSName: "new-record.org",
|
|
Target: "new-lb.org",
|
|
RecordType: "CNAME",
|
|
},
|
|
}
|
|
|
|
p.ApplyChanges("zone", &plan.Changes{
|
|
Create: providerRecords,
|
|
})
|
|
|
|
// wrong zone
|
|
r, _ := NewNoopRegistry(p)
|
|
err := r.ApplyChanges("wrong-zone", &plan.Changes{})
|
|
if err != provider.ErrZoneNotFound {
|
|
t.Error("should return zone not found for apply changes on wrong zone")
|
|
}
|
|
|
|
// wrong changes
|
|
r, _ = NewNoopRegistry(p)
|
|
err = r.ApplyChanges("zone", &plan.Changes{
|
|
Create: []*endpoint.Endpoint{
|
|
{
|
|
DNSName: "example.org",
|
|
Target: "lb.com",
|
|
},
|
|
},
|
|
})
|
|
if err != provider.ErrRecordAlreadyExists {
|
|
t.Error("should return record already exists")
|
|
}
|
|
|
|
//correct changes
|
|
err = r.ApplyChanges("zone", &plan.Changes{
|
|
Create: []*endpoint.Endpoint{
|
|
{
|
|
DNSName: "new-record.org",
|
|
Target: "new-lb.org",
|
|
},
|
|
},
|
|
UpdateNew: []*endpoint.Endpoint{
|
|
{
|
|
DNSName: "example.org",
|
|
Target: "new-example-lb.com",
|
|
},
|
|
},
|
|
UpdateOld: []*endpoint.Endpoint{
|
|
{
|
|
DNSName: "example.org",
|
|
Target: "old-lb.com",
|
|
},
|
|
},
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
res, _ := p.Records("zone")
|
|
if !testutils.SameEndpoints(res, expectedUpdate) {
|
|
t.Error("incorrectly updated dns provider")
|
|
}
|
|
}
|