mirror of
https://github.com/kubernetes-sigs/external-dns.git
synced 2025-08-06 17:46:57 +02:00
* Add RecordTTL * Route53: test for custom TTL * Fix tests * Fix remaining tests * Add ttl when endpoint is created from ingress * Missed a word * Fix bad refactoring * Add ingress custom TTL test * gofmt * Satisfy go-lint * Unshadow `endpoint` in azure provider * Fix and add an output test * Add TTL for endpoints generated from service templates * Take TTL into account when generating update plan * Tests for TTL change impact on the plan * Refactor factory method name * Refactoring * Run gofmt * Make endpoint string format look like BIND config * Update plan and plan_test * Replace NewEndpointWithTTLValue with NewEndpointWithTTL in aws * Remove NewEndpointWithTTLValue func * Update references to TTL * Remove getTTLValue func * Handle merge conflict * Update tests * Update README, CHANGELOG and documentation * Run gofmt * Move getTTLFromAnnotations to a common file * Refactor getTTLFromAnnotations * Gofmt * Add tests for getTTLFromAnnotations * Trigger build * Add boilerplate header * Update README/CHANGELOG according to code review * Add ttl.md and link it from README * change CNAME string to endpoint.RecordTypeCNAME * fix test cases with AWS ALIAS records, these do not behave different in these tests
95 lines
2.7 KiB
Go
95 lines
2.7 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package source
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/kubernetes-incubator/external-dns/endpoint"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestGetTTLFromAnnotations(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
title string
|
|
annotations map[string]string
|
|
expectedTTL endpoint.TTL
|
|
expectedErr error
|
|
}{
|
|
{
|
|
title: "TTL annotation not present",
|
|
annotations: map[string]string{"foo": "bar"},
|
|
expectedTTL: endpoint.TTL(0),
|
|
expectedErr: nil,
|
|
},
|
|
{
|
|
title: "TTL annotation value is not a number",
|
|
annotations: map[string]string{ttlAnnotationKey: "foo"},
|
|
expectedTTL: endpoint.TTL(0),
|
|
expectedErr: fmt.Errorf("\"foo\" is not a valid TTL value"),
|
|
},
|
|
{
|
|
title: "TTL annotation value is empty",
|
|
annotations: map[string]string{ttlAnnotationKey: ""},
|
|
expectedTTL: endpoint.TTL(0),
|
|
expectedErr: fmt.Errorf("\"\" is not a valid TTL value"),
|
|
},
|
|
{
|
|
title: "TTL annotation value is negative number",
|
|
annotations: map[string]string{ttlAnnotationKey: "-1"},
|
|
expectedTTL: endpoint.TTL(0),
|
|
expectedErr: fmt.Errorf("TTL value must be between [%d, %d]", ttlMinimum, ttlMaximum),
|
|
},
|
|
{
|
|
title: "TTL annotation value is too high",
|
|
annotations: map[string]string{ttlAnnotationKey: fmt.Sprintf("%d", 1<<32)},
|
|
expectedTTL: endpoint.TTL(0),
|
|
expectedErr: fmt.Errorf("TTL value must be between [%d, %d]", ttlMinimum, ttlMaximum),
|
|
},
|
|
{
|
|
title: "TTL annotation value is set correctly",
|
|
annotations: map[string]string{ttlAnnotationKey: "60"},
|
|
expectedTTL: endpoint.TTL(60),
|
|
expectedErr: nil,
|
|
},
|
|
} {
|
|
t.Run(tc.title, func(t *testing.T) {
|
|
ttl, err := getTTLFromAnnotations(tc.annotations)
|
|
assert.Equal(t, tc.expectedTTL, ttl)
|
|
assert.Equal(t, tc.expectedErr, err)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSuitableType(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
target, recordType, expected string
|
|
}{
|
|
{"8.8.8.8", "", "A"},
|
|
{"foo.example.org", "", "CNAME"},
|
|
{"bar.eu-central-1.elb.amazonaws.com", "", "CNAME"},
|
|
} {
|
|
|
|
recordType := suitableType(tc.target)
|
|
|
|
if recordType != tc.expected {
|
|
t.Errorf("expected %s, got %s", tc.expected, recordType)
|
|
}
|
|
}
|
|
}
|