mirror of
https://github.com/kubernetes-sigs/external-dns.git
synced 2025-11-01 03:00:59 +01:00
585d752ca4
This change disables the CRD source's informer during tests. I made the mistake of not running `make test` before the previous commit, and thus didn't realize that leaving the informer enabled during the tests introduced a race condition: WARNING: DATA RACE Write at 0x00c0005aa130 by goroutine 59: k8s.io/client-go/rest/fake.(*RESTClient).do() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/fake/fake.go:113 +0x69 k8s.io/client-go/rest/fake.(*RESTClient).do-fm() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/fake/fake.go:109 +0x64 k8s.io/client-go/rest/fake.roundTripperFunc.RoundTrip() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/fake/fake.go:43 +0x3d net/http.send() /usr/local/go/src/net/http/client.go:251 +0x6da net/http.(*Client).send() /usr/local/go/src/net/http/client.go:175 +0x1d5 net/http.(*Client).do() /usr/local/go/src/net/http/client.go:717 +0x2cb net/http.(*Client).Do() /usr/local/go/src/net/http/client.go:585 +0x68b k8s.io/client-go/rest.(*Request).request() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/request.go:855 +0x209 k8s.io/client-go/rest.(*Request).Do() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/request.go:928 +0xf0 sigs.k8s.io/external-dns/source.(*crdSource).List() /Users/erath/go/src/github.com/ericrrath/external-dns/source/crd.go:250 +0x28c sigs.k8s.io/external-dns/source.NewCRDSource.func1() /Users/erath/go/src/github.com/ericrrath/external-dns/source/crd.go:125 +0x10a k8s.io/client-go/tools/cache.(*ListWatch).List() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/cache/listwatch.go:106 +0x94 k8s.io/client-go/tools/cache.(*Reflector).ListAndWatch.func1.1.2() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/cache/reflector.go:233 +0xf4 k8s.io/client-go/tools/pager.SimplePageFunc.func1() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/pager/pager.go:40 +0x94 k8s.io/client-go/tools/pager.(*ListPager).List() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/pager/pager.go:91 +0x1f4 k8s.io/client-go/tools/cache.(*Reflector).ListAndWatch.func1.1() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/cache/reflector.go:258 +0x2b7 Previous write at 0x00c0005aa130 by goroutine 37: k8s.io/client-go/rest/fake.(*RESTClient).do() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/fake/fake.go:113 +0x69 k8s.io/client-go/rest/fake.(*RESTClient).do-fm() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/fake/fake.go:109 +0x64 k8s.io/client-go/rest/fake.roundTripperFunc.RoundTrip() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/fake/fake.go:43 +0x3d net/http.send() /usr/local/go/src/net/http/client.go:251 +0x6da net/http.(*Client).send() /usr/local/go/src/net/http/client.go:175 +0x1d5 net/http.(*Client).do() /usr/local/go/src/net/http/client.go:717 +0x2cb net/http.(*Client).Do() /usr/local/go/src/net/http/client.go:585 +0x68b k8s.io/client-go/rest.(*Request).request() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/request.go:855 +0x209 k8s.io/client-go/rest.(*Request).Do() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/rest/request.go:928 +0xf0 sigs.k8s.io/external-dns/source.(*crdSource).List() /Users/erath/go/src/github.com/ericrrath/external-dns/source/crd.go:250 +0x28c sigs.k8s.io/external-dns/source.(*crdSource).Endpoints() /Users/erath/go/src/github.com/ericrrath/external-dns/source/crd.go:171 +0x13c4 sigs.k8s.io/external-dns/source.testCRDSourceEndpoints.func1() /Users/erath/go/src/github.com/ericrrath/external-dns/source/crd_test.go:388 +0x4f6 testing.tRunner() /usr/local/go/src/testing/testing.go:1193 +0x202 Goroutine 59 (running) created at: k8s.io/client-go/tools/cache.(*Reflector).ListAndWatch.func1() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/cache/reflector.go:224 +0x36f k8s.io/client-go/tools/cache.(*Reflector).ListAndWatch() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/cache/reflector.go:316 +0x1ab k8s.io/client-go/tools/cache.(*Reflector).Run.func1() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/cache/reflector.go:177 +0x4a k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1() /Users/erath/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:155 +0x75 k8s.io/apimachinery/pkg/util/wait.BackoffUntil() /Users/erath/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:156 +0xba k8s.io/client-go/tools/cache.(*Reflector).Run() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/cache/reflector.go:176 +0xee k8s.io/client-go/tools/cache.(*Reflector).Run-fm() /Users/erath/go/pkg/mod/k8s.io/client-go@v0.18.8/tools/cache/reflector.go:174 +0x54 k8s.io/apimachinery/pkg/util/wait.(*Group).StartWithChannel.func1() /Users/erath/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:56 +0x45 k8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1() /Users/erath/go/pkg/mod/k8s.io/apimachinery@v0.18.8/pkg/util/wait/wait.go:73 +0x6d Goroutine 37 (running) created at: testing.(*T).Run() /usr/local/go/src/testing/testing.go:1238 +0x5d7 sigs.k8s.io/external-dns/source.testCRDSourceEndpoints() /Users/erath/go/src/github.com/ericrrath/external-dns/source/crd_test.go:376 +0x1fcf testing.tRunner() /usr/local/go/src/testing/testing.go:1193 +0x202 It looks like client-go's fake.RESTClient (used by crd_test.go) is known to cause race conditions when used with informers: <https://github.com/kubernetes/kubernetes/issues/95372>. None of the CRD tests _depend_ on the informer yet, so disabling the informer at least allows the existing tests to pass without race conditions. I'll look into further changes that 1) test the new event-handler behavior, and 2) allow all tests to pass without race conditions.