mirror of
https://github.com/kubernetes-sigs/external-dns.git
synced 2025-08-06 01:26:59 +02:00
17fb8813d0
Currently, planning instructs to create all records even those which does not match any zone. Later, those records will be checked towards the existing records and filtered whether they match or not a hosted zone. This causes a problem, at least in the specific case of the Route53 implementation as it always calls the ApplyChanges method, which in its turn always retrieves all records in all zones. This causes high pressure on Route53 APIs, for non-necessary actions. By being able to filter all unmanaged records from the plan, we can prevent from calling ApplyChanges when nothing has to be done and hence prevent an unnecessary listing of records. By doing so, the rate of API calls to AWS Route53 is expected to be reduced by 2
52 lines
1.9 KiB
Go
52 lines
1.9 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package registry
|
|
|
|
import (
|
|
"context"
|
|
|
|
log "github.com/sirupsen/logrus"
|
|
|
|
"sigs.k8s.io/external-dns/endpoint"
|
|
"sigs.k8s.io/external-dns/plan"
|
|
)
|
|
|
|
// Registry is an interface which should enables ownership concept in external-dns
|
|
// Records() returns ALL records registered with DNS provider
|
|
// each entry includes owner information
|
|
// ApplyChanges(changes *plan.Changes) propagates the changes to the DNS Provider API and correspondingly updates ownership depending on type of registry being used
|
|
type Registry interface {
|
|
Records(ctx context.Context) ([]*endpoint.Endpoint, error)
|
|
ApplyChanges(ctx context.Context, changes *plan.Changes) error
|
|
PropertyValuesEqual(attribute string, previous string, current string) bool
|
|
AdjustEndpoints(endpoints []*endpoint.Endpoint) []*endpoint.Endpoint
|
|
GetDomainFilter() endpoint.DomainFilterInterface
|
|
}
|
|
|
|
//TODO(ideahitme): consider moving this to Plan
|
|
func filterOwnedRecords(ownerID string, eps []*endpoint.Endpoint) []*endpoint.Endpoint {
|
|
filtered := []*endpoint.Endpoint{}
|
|
for _, ep := range eps {
|
|
if endpointOwner, ok := ep.Labels[endpoint.OwnerLabelKey]; !ok || endpointOwner != ownerID {
|
|
log.Debugf(`Skipping endpoint %v because owner id does not match, found: "%s", required: "%s"`, ep, endpointOwner, ownerID)
|
|
continue
|
|
}
|
|
filtered = append(filtered, ep)
|
|
}
|
|
return filtered
|
|
}
|