mirror of
https://github.com/kubernetes-sigs/external-dns.git
synced 2025-08-06 09:36:58 +02:00
17fb8813d0
Currently, planning instructs to create all records even those which does not match any zone. Later, those records will be checked towards the existing records and filtered whether they match or not a hosted zone. This causes a problem, at least in the specific case of the Route53 implementation as it always calls the ApplyChanges method, which in its turn always retrieves all records in all zones. This causes high pressure on Route53 APIs, for non-necessary actions. By being able to filter all unmanaged records from the plan, we can prevent from calling ApplyChanges when nothing has to be done and hence prevent an unnecessary listing of records. By doing so, the rate of API calls to AWS Route53 is expected to be reduced by 2
62 lines
2.0 KiB
Go
62 lines
2.0 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package registry
|
|
|
|
import (
|
|
"context"
|
|
|
|
"sigs.k8s.io/external-dns/endpoint"
|
|
"sigs.k8s.io/external-dns/plan"
|
|
"sigs.k8s.io/external-dns/provider"
|
|
)
|
|
|
|
// NoopRegistry implements registry interface without ownership directly propagating changes to dns provider
|
|
type NoopRegistry struct {
|
|
provider provider.Provider
|
|
}
|
|
|
|
// NewNoopRegistry returns new NoopRegistry object
|
|
func NewNoopRegistry(provider provider.Provider) (*NoopRegistry, error) {
|
|
return &NoopRegistry{
|
|
provider: provider,
|
|
}, nil
|
|
}
|
|
|
|
func (im *NoopRegistry) GetDomainFilter() endpoint.DomainFilterInterface {
|
|
return im.provider.GetDomainFilter()
|
|
}
|
|
|
|
// Records returns the current records from the dns provider
|
|
func (im *NoopRegistry) Records(ctx context.Context) ([]*endpoint.Endpoint, error) {
|
|
return im.provider.Records(ctx)
|
|
}
|
|
|
|
// ApplyChanges propagates changes to the dns provider
|
|
func (im *NoopRegistry) ApplyChanges(ctx context.Context, changes *plan.Changes) error {
|
|
return im.provider.ApplyChanges(ctx, changes)
|
|
}
|
|
|
|
// PropertyValuesEqual compares two property values for equality
|
|
func (im *NoopRegistry) PropertyValuesEqual(attribute string, previous string, current string) bool {
|
|
return im.provider.PropertyValuesEqual(attribute, previous, current)
|
|
}
|
|
|
|
// AdjustEndpoints modifies the endpoints as needed by the specific provider
|
|
func (im *NoopRegistry) AdjustEndpoints(endpoints []*endpoint.Endpoint) []*endpoint.Endpoint {
|
|
return im.provider.AdjustEndpoints(endpoints)
|
|
}
|