external-dns/source/informers/indexers_test.go

/*
Copyright 2025 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
    http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package informers

import (
	"testing"

	"github.com/stretchr/testify/assert"
	corev1 "k8s.io/api/core/v1"
	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
	"k8s.io/apimachinery/pkg/labels"
	"k8s.io/client-go/tools/cache"
	"sigs.k8s.io/external-dns/source/annotations"
)

func TestIndexerWithOptions_FilterByAnnotation(t *testing.T) {
	indexers := IndexerWithOptions[*unstructured.Unstructured](
		IndexSelectorWithAnnotationFilter("example-annotation"),
	)

	obj := &unstructured.Unstructured{}
	obj.SetAnnotations(map[string]string{"example-annotation": "value"})
	obj.SetNamespace("default")
	obj.SetName("test-object")

	keys, err := indexers[IndexWithSelectors](obj)
	assert.NoError(t, err)
	assert.Equal(t, []string{"default/test-object"}, keys)
}

func TestIndexerWithOptions_FilterByLabel(t *testing.T) {
	labelSelector := labels.SelectorFromSet(labels.Set{"app": "nginx"})
	indexers := IndexerWithOptions[*corev1.Pod](
		IndexSelectorWithLabelSelector(labelSelector),
	)

	obj := &corev1.Pod{}
	obj.SetLabels(map[string]string{"app": "nginx"})
	obj.SetNamespace("default")
	obj.SetName("test-object")

	keys, err := indexers[IndexWithSelectors](obj)
	assert.NoError(t, err)
	assert.Equal(t, []string{"default/test-object"}, keys)
}

func TestIndexerWithOptions_NoMatch(t *testing.T) {
	labelSelector := labels.SelectorFromSet(labels.Set{"app": "nginx"})
	indexers := IndexerWithOptions[*unstructured.Unstructured](
		IndexSelectorWithLabelSelector(labelSelector),
	)

	obj := &unstructured.Unstructured{}
	obj.SetLabels(map[string]string{"app": "apache"})
	obj.SetNamespace("default")
	obj.SetName("test-object")

	keys, err := indexers[IndexWithSelectors](obj)
	assert.NoError(t, err)
	assert.Nil(t, keys)
}

func TestIndexerWithOptions_InvalidType(t *testing.T) {
	indexers := IndexerWithOptions[*unstructured.Unstructured]()

	obj := "invalid-object"

	keys, err := indexers[IndexWithSelectors](obj)
	assert.Error(t, err)
	assert.Nil(t, keys)
	assert.Contains(t, err.Error(), "object is not of type")
}

func TestIndexerWithOptions_EmptyOptions(t *testing.T) {
	indexers := IndexerWithOptions[*unstructured.Unstructured]()

	obj := &unstructured.Unstructured{}
	obj.SetNamespace("default")
	obj.SetName("test-object")

	keys, err := indexers["withSelectors"](obj)
	assert.NoError(t, err)
	assert.Equal(t, []string{"default/test-object"}, keys)
}

func TestIndexerWithOptions_AnnotationFilterNoMatch(t *testing.T) {
	indexers := IndexerWithOptions[*unstructured.Unstructured](
		IndexSelectorWithAnnotationFilter("example-annotation=value"),
	)

	obj := &unstructured.Unstructured{}
	obj.SetAnnotations(map[string]string{"other-annotation": "value"})
	obj.SetNamespace("default")
	obj.SetName("test-object")

	keys, err := indexers[IndexWithSelectors](obj)
	assert.NoError(t, err)
	assert.Nil(t, keys)
}

func TestIndexSelectorWithAnnotationFilter(t *testing.T) {
	tests := []struct {
		name           string
		input          string
		expectedFilter labels.Selector
	}{
		{
			name:           "valid input",
			input:          "key=value",
			expectedFilter: func() labels.Selector { s, _ := annotations.ParseFilter("key=value"); return s }(),
		},
		{
			name:           "empty input",
			input:          "",
			expectedFilter: nil,
		},
		{
			name:           "key only filter",
			input:          "app",
			expectedFilter: func() labels.Selector { s, _ := annotations.ParseFilter("app"); return s }(),
		},
		{
			name:           "poisoned input",
			input:          "=app",
			expectedFilter: nil,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			options := &IndexSelectorOptions{}
			IndexSelectorWithAnnotationFilter(tt.input)(options)
			assert.Equal(t, tt.expectedFilter, options.annotationFilter)
		})
	}
}

func TestGetByKey_ObjectExists(t *testing.T) {
	indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{})
	pod := &corev1.Pod{}
	pod.SetNamespace("default")
	pod.SetName("test-pod")

	err := indexer.Add(pod)
	assert.NoError(t, err)

	result, err := GetByKey[*corev1.Pod](indexer, "default/test-pod")
	assert.NoError(t, err)
	assert.NotNil(t, result)
	assert.Equal(t, "test-pod", result.GetName())
}

func TestGetByKey_ObjectDoesNotExist(t *testing.T) {
	indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{})

	result, err := GetByKey[*corev1.Pod](indexer, "default/non-existent-pod")
	assert.NoError(t, err)
	assert.Nil(t, result)
}

func TestGetByKey_TypeAssertionFailure(t *testing.T) {
	indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{})
	service := &corev1.Service{}
	service.SetNamespace("default")
	service.SetName("test-service")

	err := indexer.Add(service)
	assert.NoError(t, err)

	result, err := GetByKey[*corev1.Pod](indexer, "default/test-service")
	assert.Error(t, err)
	assert.Contains(t, err.Error(), "object is not of type")
	assert.Nil(t, result)
}

func TestIndexerSpecSelector_Service(t *testing.T) {
	indexers := IndexerSpecSelector[*corev1.Service]()
	svc := &corev1.Service{}
	svc.Spec.Selector = map[string]string{"app": "demo", "tier": "backend"}

	keys, err := indexers[IndexWithSpecSelector](svc)
	assert.NoError(t, err)
	expected := ToSHA(labels.Set(svc.Spec.Selector).String())
	assert.Equal(t, []string{expected}, keys)
}

func TestIndexerSpecSelector_NonService(t *testing.T) {
	indexers := IndexerSpecSelector[*corev1.Service]()
	obj := "not-a-service"

	keys, err := indexers[IndexWithSpecSelector](obj)
	assert.NoError(t, err)
	assert.Nil(t, keys)
}

func TestIndexerSpecSelector_EmptySelector(t *testing.T) {
	indexers := IndexerSpecSelector[*corev1.Service]()
	svc := &corev1.Service{}
	svc.Spec.Selector = map[string]string{}

	keys, err := indexers[IndexWithSpecSelector](svc)
	assert.NoError(t, err)
	expected := ToSHA(labels.Set(svc.Spec.Selector).String())
	assert.Equal(t, []string{expected}, keys)
}