external-dns/source/istio_virtualservice.go
Ivan Ka 56e00e6667
perf(source/istio): replace API calls with indexed informer cache for gateway and virtualservice sources (#6303)
* perf(source/istio): replace API calls with indexed informer cache for gateway and virtualservice sources

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* perf(source/istio): replace API calls with indexed informer cache for gateway and virtualservice sources

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

---------

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2026-03-28 14:04:13 +05:30

416 lines
15 KiB
Go

/*
Copyright 2020 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package source
import (
"cmp"
"context"
"fmt"
"slices"
"strings"
log "github.com/sirupsen/logrus"
networkingv1 "istio.io/client-go/pkg/apis/networking/v1"
istioclient "istio.io/client-go/pkg/clientset/versioned"
istioinformers "istio.io/client-go/pkg/informers/externalversions"
networkingv1informer "istio.io/client-go/pkg/informers/externalversions/networking/v1"
corev1 "k8s.io/api/core/v1"
networkv1 "k8s.io/api/networking/v1"
"k8s.io/apimachinery/pkg/api/errors"
kubeinformers "k8s.io/client-go/informers"
coreinformers "k8s.io/client-go/informers/core/v1"
netinformers "k8s.io/client-go/informers/networking/v1"
"k8s.io/client-go/kubernetes"
"sigs.k8s.io/external-dns/source/types"
"sigs.k8s.io/external-dns/endpoint"
"sigs.k8s.io/external-dns/source/annotations"
"sigs.k8s.io/external-dns/source/informers"
"sigs.k8s.io/external-dns/source/template"
)
// IstioMeshGateway is the built in gateway for all sidecars
const IstioMeshGateway = "mesh"
// virtualServiceSource is an implementation of Source for Istio VirtualService objects.
// The implementation uses the spec.hosts values for the hostnames.
// Use annotations.TargetKey to explicitly set Endpoint.
//
// +externaldns:source:name=istio-virtualservice
// +externaldns:source:category=Service Mesh
// +externaldns:source:description=Creates DNS entries from Istio VirtualService resources
// +externaldns:source:resources=VirtualService.networking.istio.io
// +externaldns:source:filters=annotation,label
// +externaldns:source:namespace=all,single
// +externaldns:source:fqdn-template=true
// +externaldns:source:provider-specific=true
type virtualServiceSource struct {
namespace string
annotationFilter string
templateEngine template.Engine
ignoreHostnameAnnotation bool
serviceInformer coreinformers.ServiceInformer
vServiceInformer networkingv1informer.VirtualServiceInformer
gatewayInformer networkingv1informer.GatewayInformer
ingressInformer netinformers.IngressInformer
}
// NewIstioVirtualServiceSource creates a new virtualServiceSource with the given config.
func NewIstioVirtualServiceSource(
ctx context.Context,
kubeClient kubernetes.Interface,
istioClient istioclient.Interface,
cfg *Config,
) (Source, error) {
// Use shared informers to listen for add/update/delete of services/pods/nodes in the specified namespace.
// Set resync period to 0, to prevent processing when nothing has changed
informerFactory := kubeinformers.NewSharedInformerFactoryWithOptions(kubeClient, 0, kubeinformers.WithNamespace(cfg.Namespace))
serviceInformer := informerFactory.Core().V1().Services()
istioInformerFactory := istioinformers.NewSharedInformerFactoryWithOptions(istioClient, 0, istioinformers.WithNamespace(cfg.Namespace))
virtualServiceInformer := istioInformerFactory.Networking().V1().VirtualServices()
gatewayInformer := istioInformerFactory.Networking().V1().Gateways()
ingressInformer := informerFactory.Networking().V1().Ingresses()
informers.MustSetTransform(serviceInformer.Informer(), informers.TransformerWithOptions[*corev1.Service](
informers.TransformRemoveManagedFields(),
informers.TransformRemoveLastAppliedConfig(),
informers.TransformRemoveStatusConditions(),
))
informers.MustSetTransform(ingressInformer.Informer(), informers.TransformerWithOptions[*networkv1.Ingress](
informers.TransformRemoveManagedFields(),
informers.TransformRemoveLastAppliedConfig(),
))
informers.MustSetTransform(virtualServiceInformer.Informer(), informers.TransformerWithOptions[*networkingv1.VirtualService](
informers.TransformRemoveManagedFields(),
informers.TransformRemoveLastAppliedConfig(),
))
informers.MustSetTransform(gatewayInformer.Informer(), informers.TransformerWithOptions[*networkingv1.Gateway](
informers.TransformRemoveManagedFields(),
informers.TransformRemoveLastAppliedConfig(),
))
informers.MustAddIndexers(virtualServiceInformer.Informer(), informers.IndexerWithOptions[*networkingv1.VirtualService](
informers.IndexSelectorWithAnnotationFilter(cfg.AnnotationFilter),
informers.IndexSelectorWithLabelSelector(cfg.LabelFilter),
))
// Add default resource event handlers to properly initialize informer.
informers.MustAddEventHandler(ingressInformer.Informer(), informers.DefaultEventHandler())
informers.MustAddEventHandler(serviceInformer.Informer(), informers.DefaultEventHandler())
informers.MustAddEventHandler(virtualServiceInformer.Informer(), informers.DefaultEventHandler())
informers.MustAddEventHandler(gatewayInformer.Informer(), informers.DefaultEventHandler())
informerFactory.Start(ctx.Done())
istioInformerFactory.Start(ctx.Done())
// wait for the local cache to be populated.
if err := informers.WaitForCacheSync(ctx, informerFactory); err != nil {
return nil, err
}
if err := informers.WaitForCacheSync(ctx, istioInformerFactory); err != nil {
return nil, err
}
return &virtualServiceSource{
namespace: cfg.Namespace,
annotationFilter: cfg.AnnotationFilter,
templateEngine: cfg.TemplateEngine,
ignoreHostnameAnnotation: cfg.IgnoreHostnameAnnotation,
serviceInformer: serviceInformer,
vServiceInformer: virtualServiceInformer,
gatewayInformer: gatewayInformer,
ingressInformer: ingressInformer,
}, nil
}
// Endpoints returns endpoint objects for each host-target combination that should be processed.
// Retrieves all VirtualService resources in the source's namespace(s).
func (sc *virtualServiceSource) Endpoints(ctx context.Context) ([]*endpoint.Endpoint, error) {
indexer := sc.vServiceInformer.Informer().GetIndexer()
indexKeys := indexer.ListIndexFuncValues(informers.IndexWithSelectors)
endpoints := make([]*endpoint.Endpoint, 0, len(indexKeys))
log.Debugf("Found %d virtualservice in namespace %s", len(indexKeys), sc.namespace)
for _, key := range indexKeys {
vService, err := informers.GetByKey[*networkingv1.VirtualService](indexer, key)
if err != nil || vService == nil {
continue
}
if annotations.IsControllerMismatch(vService, types.IstioVirtualService) {
continue
}
gwEndpoints, err := sc.endpointsFromVirtualService(ctx, vService)
if err != nil {
return nil, err
}
// apply template if host is missing on VirtualService
gwEndpoints, err = sc.templateEngine.CombineWithEndpoints(
gwEndpoints,
func() ([]*endpoint.Endpoint, error) { return sc.endpointsFromTemplate(ctx, vService) },
)
if err != nil {
return nil, err
}
if endpoint.HasNoEmptyEndpoints(gwEndpoints, types.IstioVirtualService, vService) {
continue
}
log.Debugf("Endpoints generated from '%s/%s/%s': %q", strings.ToLower(vService.Kind), vService.Namespace, vService.Name, gwEndpoints)
endpoints = append(endpoints, gwEndpoints...)
}
return MergeEndpoints(endpoints), nil
}
// AddEventHandler adds an event handler that should be triggered if the watched Istio VirtualService changes.
func (sc *virtualServiceSource) AddEventHandler(_ context.Context, handler func()) {
log.Debug("Adding event handler for Istio VirtualService")
informers.MustAddEventHandler(sc.vServiceInformer.Informer(), eventHandlerFunc(handler))
}
func (sc *virtualServiceSource) getGateway(_ context.Context, gatewayStr string, virtualService *networkingv1.VirtualService) (*networkingv1.Gateway, error) {
if gatewayStr == "" || gatewayStr == IstioMeshGateway {
// This refers to "all sidecars in the mesh"; ignore.
return nil, nil
}
namespace, name, err := ParseIngress(gatewayStr)
if err != nil {
log.Debugf("Failed parsing gatewayStr %s of VirtualService %s/%s", gatewayStr, virtualService.Namespace, virtualService.Name)
return nil, err
}
namespace = cmp.Or(namespace, virtualService.Namespace)
gateway, err := sc.gatewayInformer.Lister().Gateways(namespace).Get(name)
if errors.IsNotFound(err) {
log.Warnf("VirtualService (%s/%s) references non-existent gateway: %s ", virtualService.Namespace, virtualService.Name, gatewayStr)
return gateway, nil
} else if err != nil {
log.Errorf("Failed retrieving gateway %s referenced by VirtualService %s/%s: %v", gatewayStr, virtualService.Namespace, virtualService.Name, err)
return nil, err
}
if gateway == nil {
log.Debugf("Gateway %s referenced by VirtualService %s/%s not found: %v", gatewayStr, virtualService.Namespace, virtualService.Name, err)
return gateway, nil
}
return gateway, nil
}
func (sc *virtualServiceSource) endpointsFromTemplate(ctx context.Context, virtualService *networkingv1.VirtualService) ([]*endpoint.Endpoint, error) {
hostnames, err := sc.templateEngine.ExecFQDN(virtualService)
if err != nil {
return nil, err
}
resource := fmt.Sprintf("virtualservice/%s/%s", virtualService.Namespace, virtualService.Name)
ttl := annotations.TTLFromAnnotations(virtualService.Annotations, resource)
providerSpecific, setIdentifier := annotations.ProviderSpecificAnnotations(virtualService.Annotations)
var endpoints []*endpoint.Endpoint
for _, hostname := range hostnames {
targets, err := sc.targetsFromVirtualService(ctx, virtualService, hostname)
if err != nil {
return endpoints, err
}
endpoints = append(endpoints, endpoint.EndpointsForHostname(hostname, targets, ttl, providerSpecific, setIdentifier, resource)...)
}
return endpoints, nil
}
// append a target to the list of targets unless it's already in the list
func (sc *virtualServiceSource) targetsFromVirtualService(ctx context.Context, vService *networkingv1.VirtualService, vsHost string) ([]string, error) {
var targets []string
// for each host we need to iterate through the gateways because each host might match for only one of the gateways
for _, gateway := range vService.Spec.Gateways {
gw, err := sc.getGateway(ctx, gateway, vService)
if err != nil {
return nil, err
}
if gw == nil {
continue
}
if !virtualServiceBindsToGateway(vService, gw, vsHost) {
continue
}
tgs, err := sc.targetsFromGateway(gw)
if err != nil {
return targets, err
}
for _, target := range tgs {
if !slices.Contains(targets, target) {
targets = append(targets, target)
}
}
}
return targets, nil
}
// endpointsFromVirtualService extracts the endpoints from an Istio VirtualService Config object
func (sc *virtualServiceSource) endpointsFromVirtualService(ctx context.Context, vService *networkingv1.VirtualService) ([]*endpoint.Endpoint, error) {
var endpoints []*endpoint.Endpoint
var err error
resource := fmt.Sprintf("virtualservice/%s/%s", vService.Namespace, vService.Name)
ttl := annotations.TTLFromAnnotations(vService.Annotations, resource)
targetsFromAnnotation := annotations.TargetsFromTargetAnnotation(vService.Annotations)
providerSpecific, setIdentifier := annotations.ProviderSpecificAnnotations(vService.Annotations)
for _, host := range vService.Spec.Hosts {
if host == "" || host == "*" {
continue
}
parts := strings.Split(host, "/")
// If the input hostname is of the form my-namespace/foo.bar.com, remove the namespace
// before appending it to the list of endpoints to create
if len(parts) == 2 {
host = parts[1]
}
targets := targetsFromAnnotation
if len(targets) == 0 {
targets, err = sc.targetsFromVirtualService(ctx, vService, host)
if err != nil {
return endpoints, err
}
}
endpoints = append(endpoints, endpoint.EndpointsForHostname(host, targets, ttl, providerSpecific, setIdentifier, resource)...)
}
// Skip endpoints if we do not want entries from annotations
if !sc.ignoreHostnameAnnotation {
hostnameList := annotations.HostnamesFromAnnotations(vService.Annotations)
for _, hostname := range hostnameList {
targets := targetsFromAnnotation
if len(targets) == 0 {
targets, err = sc.targetsFromVirtualService(ctx, vService, hostname)
if err != nil {
return endpoints, err
}
}
endpoints = append(endpoints, endpoint.EndpointsForHostname(hostname, targets, ttl, providerSpecific, setIdentifier, resource)...)
}
}
return endpoints, nil
}
// checks if the given VirtualService should actually bind to the given gateway
// see requirements here: https://istio.io/docs/reference/config/networking/gateway/#Server
func virtualServiceBindsToGateway(vService *networkingv1.VirtualService, gateway *networkingv1.Gateway, vsHost string) bool {
isValid := false
if len(vService.Spec.ExportTo) == 0 {
isValid = true
} else {
for _, ns := range vService.Spec.ExportTo {
if ns == "*" || ns == gateway.Namespace || (ns == "." && gateway.Namespace == vService.Namespace) {
isValid = true
}
}
}
if !isValid {
return false
}
for _, server := range gateway.Spec.Servers {
for _, host := range server.Hosts {
namespace := "*"
parts := strings.Split(host, "/")
if len(parts) == 2 {
namespace = parts[0]
host = parts[1]
} else if len(parts) != 1 {
log.Debugf("Gateway %s/%s has invalid host %s", gateway.Namespace, gateway.Name, host)
continue
}
if namespace == "*" || namespace == vService.Namespace || (namespace == "." && vService.Namespace == gateway.Namespace) {
if host == "*" {
return true
}
suffixMatch := false
if strings.HasPrefix(host, "*.") {
suffixMatch = true
}
if host == vsHost || (suffixMatch && strings.HasSuffix(vsHost, host[1:])) {
return true
}
}
}
}
return false
}
func (sc *virtualServiceSource) targetsFromIngress(ingressStr string, gateway *networkingv1.Gateway) (endpoint.Targets, error) {
namespace, name, err := ParseIngress(ingressStr)
if err != nil {
return nil, fmt.Errorf("failed to parse Ingress annotation on Gateway (%s/%s): %w", gateway.Namespace, gateway.Name, err)
}
if namespace == "" {
namespace = gateway.Namespace
}
ingress, err := sc.ingressInformer.Lister().Ingresses(namespace).Get(name)
if err != nil {
log.Error(err)
return nil, err
}
targets := make(endpoint.Targets, 0)
for _, lb := range ingress.Status.LoadBalancer.Ingress {
if lb.IP != "" {
targets = append(targets, lb.IP)
} else if lb.Hostname != "" {
targets = append(targets, lb.Hostname)
}
}
return targets, nil
}
func (sc *virtualServiceSource) targetsFromGateway(gateway *networkingv1.Gateway) (endpoint.Targets, error) {
targets := annotations.TargetsFromTargetAnnotation(gateway.Annotations)
if len(targets) > 0 {
return targets, nil
}
ingressStr, ok := gateway.Annotations[IstioGatewayIngressSource]
if ok && ingressStr != "" {
return sc.targetsFromIngress(ingressStr, gateway)
}
return EndpointTargetsFromServices(sc.serviceInformer, sc.namespace, gateway.Spec.Selector)
}