/* Copyright 2025 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package source import ( "fmt" "slices" "strings" log "github.com/sirupsen/logrus" "sigs.k8s.io/external-dns/endpoint" ) // ParseIngress parses an ingress string in the format "namespace/name" or "name". // It returns the namespace and name extracted from the string, or an error if the format is invalid. // If the namespace is not provided, it defaults to an empty string. func ParseIngress(ingress string) (string, string, error) { var namespace, name string var err error parts := strings.Split(ingress, "/") switch len(parts) { case 2: namespace, name = parts[0], parts[1] case 1: name = parts[0] default: err = fmt.Errorf("invalid ingress name (name or namespace/name) found %q", ingress) } return namespace, name, err } // MergeEndpoints merges endpoints with the same key (DNSName + RecordType + SetIdentifier + RecordTTL) // by combining their targets. CNAME endpoints are not merged (per DNS spec) but are deduplicated. // This is useful when multiple resources (e.g., pods, nodes) contribute targets to the same DNS record. // // TODO: move this to endpoint/utils.go func MergeEndpoints(endpoints []*endpoint.Endpoint) []*endpoint.Endpoint { if len(endpoints) == 0 { return endpoints } endpointMap := make(map[endpoint.EndpointKey]*endpoint.Endpoint) cnameTargets := make(map[string]string) // DNSName+SetIdentifier -> first target seen for _, ep := range endpoints { if ep.RecordType == endpoint.RecordTypeCNAME && len(ep.Targets) == 0 { log.Debugf("Skipping CNAME endpoint %q with no targets", ep.DNSName) continue } key := endpoint.EndpointKey{ DNSName: ep.DNSName, RecordType: ep.RecordType, SetIdentifier: ep.SetIdentifier, RecordTTL: ep.RecordTTL, } // CNAME records can only have one target per DNS spec, and they should not be merged. if ep.RecordType == endpoint.RecordTypeCNAME { key.Target = ep.Targets[0] cnameKey := ep.DNSName + "/" + ep.SetIdentifier if existing, ok := cnameTargets[cnameKey]; ok && existing != ep.Targets[0] { // This will be caught by the provider when it tries to create the record, but log a warning here to make it more obvious. // TODO: add metric for CNAME conflicts log.Warnf("Only one CNAME per name — %s CNAME %s and %s CNAME %s is invalid DNS. A resolver wouldn't know which canonical name to follow.", ep.DNSName, existing, ep.DNSName, ep.Targets[0]) } cnameTargets[cnameKey] = ep.Targets[0] } if existing, ok := endpointMap[key]; ok { existing.Targets = append(existing.Targets, ep.Targets...) } else { endpointMap[key] = ep } } result := make([]*endpoint.Endpoint, 0, len(endpointMap)) for _, ep := range endpointMap { slices.Sort(ep.Targets) ep.Targets = slices.Compact(ep.Targets) result = append(result, ep) } return result }