28 Commits

Author SHA1 Message Date
Pascal Bourdier
699e994a9c
ci(linter): add go-critic (#5875)
* ci: add go-critic linter

follow go-critic advices when possible

* docs: add a short description about go-critic
2025-10-01 09:06:19 -07:00
Ivan Ka
6e2fc4aa31
chore(codebase): enable linter nonamedreturns (#5594)
* chore(codebase): enable linter nonamedreturns

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(codebase): enable linter nonamedreturns

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

---------

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2025-07-01 22:13:25 -07:00
Ivan Ka
d30674b650
chore(codebase): enable linter recvcheck (#5522)
* chore(codebase): enable linter recvcheck

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(codebase): enable linter recvcheck

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(codebase): enable linter recvcheck

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

---------

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2025-06-22 03:22:59 -07:00
kaikai
a4522f0b76
chore(domainfilter): use pointer receivers for DomainFilter (#5546)
* refactor(domainfilter): use pointer receivers for DomainFilter

* refactor(domainfilter): complete pointer type consistency across providers
2025-06-21 00:38:53 -07:00
Romain Beuque
226c45e766
fix(ovh): correct handling of records deletion (#5450)
Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
2025-06-08 02:24:22 -07:00
ivan katliarchuk
11fd3a87aa
chore(codebase): enable copyloopvar 2025-05-20 09:37:39 +01:00
Romain Beuque
39def3fbfd fix: ovh: handling capitalized DNS records + prevent panic
Better handling of case aware endpoint by lower-casing all the
sub-domain part.

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
2025-05-14 08:59:10 +00:00
Ivan Ka
a6243cf6bb
chore(providers): rename custom TTL constants to defaultTTL (#5312)
* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

---------

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2025-04-27 14:59:25 -07:00
ivan katliarchuk
757a57609f
chore(code-quality): linter warnings fixes
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2025-04-23 22:03:00 +01:00
Michel Loiseleur
3835c62bb6 chore(ci): update linter to v2.0.2 2025-04-02 08:53:54 +02:00
Ivan Ka
f6d49ddbe8
feat(banner): standardize user agent and output (#5154)
* chore(banner): add banner

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(banner): add banner

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(banner): add banner

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(banner): add banner

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* feat(banner): standartise user agent and output banner

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

---------

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2025-03-24 01:16:40 -07:00
Romain Beuque
ecd57c86f5
feat(ovh): major rewriting of the provider (#5143)
* feat: ovh: improve cache invalidation on errors + dry-run mode + relative CNAME handling + optimization

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>

* chore: add more tests

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>

* fix: align cache expiration with Default value

* chore: address comments from review + updated documentation

* chore: address comments from review

---------

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
2025-03-17 07:53:49 -07:00
Nicolas Maupu
fc5787979d Added a comment to explain why we copy the for elt 2025-01-14 15:35:42 +01:00
Nicolas Maupu
4b1ee06618 Fixing changes type 2025-01-06 16:02:37 +01:00
Nicolas Maupu
ae4ebf5af0 lint 2024-12-23 09:00:42 +01:00
Nicolas Maupu
b7c7123982
Removing temporary and useless vars
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
2024-12-22 12:21:17 +01:00
Nicolas Maupu
4e899ca37d
Removing temporary and useless vars
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
2024-12-22 12:21:09 +01:00
Nicolas Maupu
f6741545da Removed useless newline 2024-12-21 19:49:17 +01:00
Nicolas Maupu
89aa8e1620
Fixing log from info -> debug
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
2024-12-21 19:43:43 +01:00
Nicolas Maupu
4fc95194fa
Removing debug information
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
2024-12-21 19:42:55 +01:00
Nicolas Maupu
95d9c3c71d OVH: fixing cache refresh issues and duplicates
- Cache was not updated when a change occurred which resulted in a
change to be redone at each loop
- OVH DNS can have multiple times the exact same entry. Make sure we
process all the IDs (instead of picking indefinitely the first one)
2024-12-05 12:32:36 +01:00
Romain Beuque
1a48cb8e16 feat(ovh): add cache based on DNS zone SOA value
OVHcloud customers using 'ovh' provider for large DNS zone will spend a
lot of time waiting for all records to be retrieved from the API. As
records can't change without a modification of the SOA Serial of the DNS
zone, this commit adds a client-side cache that stores the value of the
DNS records for each zone, based of the current SOA Serial value of the
zone. In case the SOA Serial of the zone is identical to the one in
cache, we can serve all the records directly from cache. Otherwise,
fallback on refreshing the cache from the API.

Signed-off-by: Romain Beuque <556072+rbeuque74@users.noreply.github.com>
2023-07-17 10:14:01 +00:00
Jesse Gonzalez
2296119619
chore(provider/ovh): Running go fmt on provider/ovh to fix the build. 2023-01-10 00:26:20 -06:00
Manuel Rüger
cfabcad9bc provider/ovh: Fix import 2023-01-06 08:03:22 +01:00
Hugome
ba5afe9518
Add OVH API rate limiting option 2020-06-09 08:56:32 +02:00
Nick Jüttner
3388e3ddf1 improve linter quality for external-dns 2020-06-06 22:29:24 +02:00
Adam Stankiewicz
f008e894df Allow for custom property comparators
Fixes issue #1463

Co-authored-by: Alastair Houghton <alastair@alastairs-place.net>
2020-05-12 16:27:46 +02:00
Raffaele Di Fazio
db4224c705 restructures the providers (build only)
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
2020-05-08 13:05:17 +02:00