Commit Graph

54 Commits

Author SHA1 Message Date
Ivan Ka
a6243cf6bb
chore(providers): rename custom TTL constants to defaultTTL (#5312)
* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

* chore(provider): inline providers

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>

---------

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2025-04-27 14:59:25 -07:00
ivan katliarchuk
abdf8bbc02
chore(refactore): added lint checks
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2025-04-23 08:22:43 +01:00
Raffaele Di Fazio
3e9f4642e3 use json to unmarshal json
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
2025-04-15 09:30:37 +02:00
Raffaele Di Fazio
b38d6bc867 changes to goccy yaml
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
2025-04-15 08:42:00 +02:00
Michel Loiseleur
a3ac49e269 fix test name 2025-02-19 15:03:37 +01:00
Andre Aguas
c2dc4bdb1b Add NS record support for Azure DNS
Azure supports NS records on public DNS zones: https://learn.microsoft.com/en-us/rest/api/dns/record-sets/create-or-update?view=rest-dns-2018-05-01&tabs=HTTP#create-ns-recordset
This PR adds this support to external dns. The implementation is similar to the other records.

Besides the unit tests this PR was also tested by creating a DNSEndpoint with the following spec:
```
    endpoints:
    - dnsName: cloud.k8gb.io
      recordTTL: 5
      recordType: NS
      targets:
      - gslb-ns-eu-cloud.k8gb.io
      - gslb-ns-us-cloud.k8gb.io
```
The creation of the NS record in Azure was successful:
```
az network dns record-set ns list --resource-group rg-k8gb  --zone-name "$EDGE_DNS_ZONE" --output json
[
  {...},
  {
    "NSRecords": [
      {
        "nsdname": "gslb-ns-eu-cloud.k8gb.io"
      },
      {
        "nsdname": "gslb-ns-us-cloud.k8gb.io"
      }
    ],
    "TTL": 5,
    "etag": "97a7199f-3be9-47bd-ab00-37013b775180",
    "fqdn": "cloud.k8gb.io.",
    "id": "/subscriptions/<redacted>/resourceGroups/rg-k8gb/providers/Microsoft.Network/dnszones/k8gb.io/NS/cloud",
    "name": "cloud",
    "provisioningState": "Succeeded",
    "resourceGroup": "rg-k8gb",
    "targetResource": {},
    "trafficManagementProfile": {},
    "type": "Microsoft.Network/dnszones/NS"
  }
]
```

This change was already attempted in #2835, but it was never merged due to inactivity.

Signed-off-by: Andre Aguas <andre.aguas@protonmail.com>
2024-11-04 23:02:10 +01:00
tanujd11
f6bafb14e1 addressed review comments
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2024-10-17 01:48:38 +05:30
tanujd11
faced93ba2 feature: add azure zone list cache
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2024-10-16 16:48:42 +05:30
Khue Doan
b16d1b3a4b Merge branch 'master' into az-private-dns-zone-name-filter 2024-04-26 00:31:11 +07:00
Jeremy-Boyle
fe0af65a14 Removed the env, and moved to config file changes for ADD endpoints, need to update docs next 2024-04-16 09:58:31 -07:00
Khue Doan
2cad978659 test(azure): Azure Private DNS apply change with zone name filter 2024-03-28 20:38:22 +07:00
Khue Doan
aa396a9a2f test(azure): Azure Private DNS zone name filter 2024-03-28 20:38:13 +07:00
Khue Doan
425dea47f3 feat(azure): add zone name filter for Azure Private DNS 2024-03-28 19:56:27 +07:00
Jeremy-Boyle
e39959d400 Adding feature for #4209
Signed-off-by: Jeremy-Boyle <9406398+Jeremy-Boyle@users.noreply.github.com>
2024-02-22 11:46:17 -06:00
Kubernetes Prow Robot
52460ba89c
Merge pull request #4186 from pascalgn/azure-subscription-id-override
feat: enable Azure subscription ID override
2024-02-15 06:00:13 -08:00
Pascal
be7cac2a56 feat: enable Azure subscription ID override 2024-02-09 12:17:44 +01:00
jeanfrancoislelezec
1b79fca437
add soft error 2024-01-22 13:43:51 +01:00
Tanuj Dwivedi
27232ffd1d
chore: fix code comment 2023-12-21 10:36:51 +05:30
jbpaux
45e2c2f677 chore(azure): refactor clientOpts 2023-09-29 19:52:23 +02:00
jbpaux
8e6d85a922 fix(azure) sovereign cloud support
Signed-off-by: jbpaux <9682558+jbpaux@users.noreply.github.com>
2023-09-29 19:49:55 +02:00
Kubernetes Prow Robot
bfe50a9432
Merge pull request #3908 from jbpaux/features/aaaa-azure
feat(azure): add AAAA records support
2023-09-15 13:02:13 -07:00
jbpaux
ae71b6c286 fix fmt to pass lint 2023-09-03 00:33:45 +02:00
jbpaux
b0ac8184ed azure: add aaaa tests 2023-09-01 23:25:23 +02:00
jbpaux
e9fb8a8f36 azure: add aaaa support 2023-09-01 23:24:35 +02:00
Igor Beliakov
a1c2775d45 feat(azure): add support for workload identity
Signed-off-by: Igor Beliakov <demtis.register@gmail.com>
2023-09-01 19:08:42 +02:00
Philip Laine
985a53217c
Update provider/azure/config.go
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
2023-08-15 09:06:11 +02:00
Philip Laine
55c93e7823
Update provider/azure/azure_private_dns.go
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
2023-08-15 09:05:28 +02:00
Philip Laine
d42df08c17
Update provider/azure/azure.go
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
2023-08-15 09:05:17 +02:00
Philip Laine
70eda8b84b Update Azure SDK and remove deprecated autorest dependency 2023-08-10 15:42:51 +02:00
Jonas-Taha El Sesiy
83d58fae03
Remove UpdateOld changeset for Azure
The underlying SDK uses `recordSetsClient.CreateOrUpdate()` [doc](https://docs.microsoft.com/en-us/rest/api/dns/record-sets/create-or-update) which allows us to exclusively rely on UpdateNew for record set updates.
As a result, we're no longer running the risk of zone update failures causing outages as outlined in #2918

Fix https://github.com/kubernetes-sigs/external-dns/issues/2918
2023-05-16 08:46:54 -07:00
Seweryn Chlewicki
93665c9e74
Update nolint comments 2023-05-02 16:01:59 +01:00
Seweryn Chlewicki
574c1025ce
Fix whitespace 2023-03-31 13:23:14 +01:00
Seweryn Chlewicki
b265cbf937
Add no lint 2023-03-31 13:14:27 +01:00
Seweryn Chlewicki
761f0e94f6
Add licence 2023-03-31 11:44:03 +01:00
Sewci0
4c02b1c648
Update common.go 2023-03-31 11:20:02 +01:00
Seweryn Chlewicki
205e8c0334
Add support for MX records in Azure, GCP and AWS 2023-03-30 20:32:32 +01:00
Raffaele Di Fazio
31e6bb8578
CI linting fixes (#3205)
* ci linting fixes

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* remove staticcheck

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* disable naming rule

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* disable stylecheck too

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* linter errors fixes

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* re-add staticcheck

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* fixes various linting issues

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* fix imports

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* fix tlsconfig

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* fix alibabacloud

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* ioutil fixes

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* remove all references to ioutil

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

* ignore linting for azure deprecated sdk

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
2022-12-02 10:57:53 -08:00
Andy Bursavich
74ffff6c26 gofumpt 2022-09-20 20:48:57 -07:00
Nick Jüttner
1840a99899 fix azure dep 2022-02-13 14:14:58 +01:00
Raffaele Di Fazio
936747c8cf removes broken test
Signed-off-by: GitHub <noreply@github.com>
2021-12-02 09:28:35 +00:00
Brett Polivka
85929ff034 [azure] remove dummy MSI_ENDPOINT 2021-10-18 01:37:04 +00:00
Raffaele Di Fazio
2344f220b4 remove wrong comment
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-08-12 09:51:59 +02:00
Raffaele Di Fazio
ab0cdd0781 reenable azure testing
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
2021-08-12 09:50:16 +02:00
Bittrance
ae1c2fa892 Downgrade Azure provider "Failed to extract" log to debug
When running the Azure provider at default log level, this messages
is 1/min and is the only messge in the log. Debug seems more
reasonable and matches what Azure Private provider.
2021-03-20 01:09:11 +01:00
Jonas-Taha El Sesiy
ec8263dc11
Address review comments 2021-01-21 09:51:32 -08:00
Jonas-Taha El Sesiy
c851a7973e
Refactor azure private dns auth
Add common config to be shared by both azure and azure-private-dns providers
Update tests & docs
2021-01-08 12:20:43 -08:00
Thibault Cohen
a706ba32ab Add test for ZoneNameFilter 2020-09-08 11:18:04 -04:00
Thibault Cohen
dac21e3aff Add --zone-name-filter option for azure provider 2020-09-02 16:23:12 -04:00
Patrick D'Addona
83d73646dc Ran goimports on provider/azure/azure_private_dns.go and provider/azure/azure_privatedns_test.go 2020-08-22 12:42:04 +02:00
Patrick D'Addona
81f0576156 Add test to verify NewAzurePrivateDNSProvider will use the ResourceManagerEndpoint from the configured cloud 2020-08-22 12:42:04 +02:00