Commit Graph

37 Commits

Author SHA1 Message Date
Markus
c0a9eed521
feat(source): optional exclusion of unschedulable nodes (#5045)
* feat(source/node): Make exclusion of unschedulable Nodes configurable

This fixes a behavioral regression introduced in #4761, where
nodes that were previously added to DNS are removed when they are considered
unschedulable, for example due to automated maintenance tasks.

This change will introduce a new flag called `exclude-unschedulable`, which
defaults to `true` in order to keep in line with the current behavior.
However, it would also be reasonable to restore the initial behavior before

* Allow testing for expected log entries in testNodeSourceEndpoints

This commit adds the required logic to be able to test for
the existence (and absence) of certain log messages
in testNodeSourceEndpoints. As an example, this is implemented
for the tests around excludeUnschedulable.

A side effect of using LogsToBuffer is that tests can't run in
parallel due to the log buffer being shared across all
parallel test cases. As such, these specific tests are now executed
one after another.

* Ensure logging is only hooked for tests that require it

* Document new exclude-unschedulable flag for nodes source
2025-04-07 07:34:40 -07:00
Ivan Ka
3fa5fc23b7
fix(node): logger test fixed (#5232)
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
2025-03-28 02:50:45 -07:00
hjoshi123
719cc78efc
removing reduntant code 2025-03-26 07:49:00 -06:00
hjoshi123
04f1661967
renaming variable 2025-03-25 20:49:11 -06:00
hjoshi123
af3a7dfef6
added new tests to handle edge case 2025-03-25 20:45:25 -06:00
hjoshi123
df517cfc9b
detailed documentation with no-expose 2025-03-24 08:20:17 -06:00
hjoshi123
ed2419a5ee
fix: removing fmt.Printf 2025-03-17 20:33:17 -06:00
hjoshi123
87e3c4bc9c
feat: added expose internal ipv6 flag 2025-03-17 08:37:06 -06:00
n-Arno
326ee0be69 source node: Skip unschedulable nodes 2024-09-20 21:17:01 +02:00
John Gardiner Myers
17e9637f11
Refactor getTTLFromAnnotations() to not return error (#3939)
* Refactor getTTLFromAnnotations() to not return error

* Improve log messages
2023-10-02 03:56:45 -07:00
John Gardiner Myers
4a32aaec01 Implement target annotation for more sources 2023-09-27 23:16:14 -07:00
John Gardiner Myers
75639b759c Support --label-filter for node source 2023-09-20 08:56:26 -07:00
John Gardiner Myers
4417ad4894 Move EndpointKey to endpoints package 2023-06-18 16:47:37 -07:00
Sandor Szücs
dc069cc10f
refactor: use always fmt.Errorf("...: %w", err), instead of %s or %v
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
2023-06-12 10:44:29 +02:00
John Gardiner Myers
4745ddbb0e Address review comment 2023-05-09 19:42:56 -07:00
John Gardiner Myers
683663e9c2 IPv6 internal node IPs are usable externally 2023-05-07 12:00:28 -07:00
Andrey Lebedev
4f41229820 Pass stop channel to informer factory instances 2022-01-22 21:31:29 +01:00
Andy Bursavich
60c649bf5c source: dedupe wait for cache sync
wait
2021-07-28 13:37:17 -07:00
Andy Bursavich
b032f2864f source: dedupe template execution 2021-07-28 13:35:51 -07:00
Andy Bursavich
638194fccd source: dedupe template parsing 2021-07-28 07:46:35 -07:00
Artem Voronin
ea9158cbf2 Fixed node nil labels map with aws-sd registry 2021-06-02 18:47:20 +03:00
Joseph Glanville
6efca134f5 dependencies: Upgrade all k8s client-go dependent sources to v1.18.X
This requires pinning grpc for now as istio client-go otherwise pulls in
breaking changes.
2020-07-03 11:29:37 +07:00
Adam Stankiewicz
1806ade2c1 Fix scheduling of reconciliation 2020-05-19 17:26:12 +02:00
Adam Stankiewicz
6e0abfaf42 Make tests faster by fast polling 2020-05-12 23:06:05 +02:00
Kubernetes Prow Robot
d49d901d8a
Merge pull request #687 from jlamillan/jlamillan/add_watch_flag
Add --watchers flag to allow controller to respond automatically to Ingress or Service updates
2020-02-04 02:23:25 -08:00
jlamillan
fed2f0f0dd
Add --events flag to use informers to automatically trigger sync loop on adds/updates/deletes for supported ingress and service sources. 2020-01-27 11:00:26 -08:00
Tariq Ibrahim
394f46cd64
uprade golangci-lint and add megacheck & interface linters 2020-01-23 14:49:23 -08:00
Tariq Ibrahim
bf4b1767fa
add more linters and improve code quality 2020-01-07 15:18:00 -08:00
Tariq Ibrahim
41ba7f1ff5
rename project root package to sigs.k8s.io 2020-01-06 08:08:35 -08:00
Nick Jüttner
f763d2a413 Move into kubernetes-sigs organization (#1245)
* Move into kubernetes-sigs organization

* Disable labeler action for forks
2019-11-01 17:10:19 +01:00
Reinier Schoof
0c547a9809 added description to exported function 2019-10-25 16:25:02 +02:00
Reinier Schoof
b6ec8557ae honor ttlAnnotationKey for node endpoints 2019-10-24 17:02:29 +02:00
Reinier Schoof
fee7046e72 error when no node address could be found 2019-10-24 16:22:31 +02:00
Martin Linkhorst
02f40d787a source: group equal DNS names into same endpoint 2019-10-24 11:21:06 +02:00
Reinier Schoof
4325d7368b respect controller annotation for node source 2019-10-01 11:39:09 +02:00
Reinier Schoof
16194ca9cf implemented annotationFilter for node source 2019-10-01 11:26:47 +02:00
Reinier Schoof
a491d8f6a2 added support for using nodes as source 2019-10-01 09:27:06 +02:00