diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f3d36d5d5..5194ed0dc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,7 @@ jobs: - name: Set up Go 1.x uses: actions/setup-go@v4 with: - go-version: 1.19 + go-version: '1.20' id: go - name: Check out code into the Go module directory @@ -38,7 +38,7 @@ jobs: apt update apt install -y make gcc libc-dev git if: github.actor == 'nektos/act' - + - name: Test run: make test diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index bf37e27d3..cadcb0488 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -30,7 +30,7 @@ jobs: - name: Install go version uses: actions/setup-go@v3 with: - go-version: '^1.19' + go-version: '^1.20' # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 112048477..b5a7decd8 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -26,7 +26,7 @@ jobs: - uses: actions/setup-go@v4 with: - go-version: ^1.19 + go-version: '^1.20' - run: | pip install -r docs/scripts/requirements.txt diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 41b9880fa..58465ce1f 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -31,5 +31,5 @@ jobs: - name: Lint run: | - curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.50.1 + curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.53.2 make lint diff --git a/.golangci.yml b/.golangci.yml index 20c72e8c2..e5a24cf6a 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -19,7 +19,6 @@ linters: # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint disable-all: true enable: - - depguard - dogsled - gofmt - goimports diff --git a/Dockerfile b/Dockerfile index db7d8dcca..341df5702 100644 --- a/Dockerfile +++ b/Dockerfile @@ -14,7 +14,7 @@ # builder image ARG ARCH -FROM golang:1.19 as builder +FROM golang:1.20 as builder ARG ARCH WORKDIR /sigs.k8s.io/external-dns diff --git a/Dockerfile.mini b/Dockerfile.mini index 90cba37d9..2428351ae 100644 --- a/Dockerfile.mini +++ b/Dockerfile.mini @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM golang:1.19 as builder +FROM golang:1.20 as builder WORKDIR /sigs.k8s.io/external-dns diff --git a/docs/contributing/getting-started.md b/docs/contributing/getting-started.md index 82976ee6d..7cf42ca09 100644 --- a/docs/contributing/getting-started.md +++ b/docs/contributing/getting-started.md @@ -1,7 +1,7 @@ # Quick Start - [Git](https://git-scm.com/downloads) -- [Go 1.19+](https://golang.org/dl/) +- [Go 1.20+](https://golang.org/dl/) - [Go modules](https://github.com/golang/go/wiki/Modules) - [golangci-lint](https://github.com/golangci/golangci-lint) - [Docker](https://docs.docker.com/install/) diff --git a/go.mod b/go.mod index 16af9aad9..4d848314c 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module sigs.k8s.io/external-dns -go 1.19 +go 1.20 require ( cloud.google.com/go/compute/metadata v0.2.3 diff --git a/provider/coredns/coredns.go b/provider/coredns/coredns.go index 356ffee73..c76525e29 100644 --- a/provider/coredns/coredns.go +++ b/provider/coredns/coredns.go @@ -37,10 +37,6 @@ import ( "sigs.k8s.io/external-dns/provider" ) -func init() { - rand.Seed(time.Now().UnixNano()) -} - const ( priority = 10 // default priority when nothing is set etcdTimeout = 5 * time.Second diff --git a/provider/rdns/rdns.go b/provider/rdns/rdns.go index e645be0bc..42feadcef 100644 --- a/provider/rdns/rdns.go +++ b/provider/rdns/rdns.go @@ -46,7 +46,7 @@ const ( ) func init() { - rand.Seed(time.Now().UnixNano()) + rand.New(rand.NewSource(time.Now().UnixNano())) } // RDNSClient is an interface to work with Rancher DNS(RDNS) records in etcdv3 backend. diff --git a/provider/tencentcloud/cloudapi/mockapi.go b/provider/tencentcloud/cloudapi/mockapi.go index 424bd6102..707579f00 100644 --- a/provider/tencentcloud/cloudapi/mockapi.go +++ b/provider/tencentcloud/cloudapi/mockapi.go @@ -18,7 +18,6 @@ package cloudapi import ( "math/rand" - "time" "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common" dnspod "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/dnspod/v20210323" @@ -34,7 +33,6 @@ type mockAPIService struct { } func NewMockService(privateZones []*privatedns.PrivateZone, privateZoneRecords map[string][]*privatedns.PrivateZoneRecord, dnspodDomains []*dnspod.DomainListItem, dnspodRecords map[string][]*dnspod.RecordListItem) *mockAPIService { - rand.Seed(time.Now().Unix()) return &mockAPIService{ privateZones: privateZones, privateZoneRecords: privateZoneRecords, diff --git a/source/fake.go b/source/fake.go index 9173f4d0a..2041c116e 100644 --- a/source/fake.go +++ b/source/fake.go @@ -25,7 +25,6 @@ import ( "fmt" "math/rand" "net" - "time" "sigs.k8s.io/external-dns/endpoint" ) @@ -40,10 +39,6 @@ const ( defaultFQDNTemplate = "example.com" ) -func init() { - rand.Seed(time.Now().UnixNano()) -} - // NewFakeSource creates a new fakeSource with the given config. func NewFakeSource(fqdnTemplate string) (Source, error) { if fqdnTemplate == "" {