diff --git a/docs/faq.md b/docs/faq.md index cfcc13ba9..527db7ccd 100644 --- a/docs/faq.md +++ b/docs/faq.md @@ -273,7 +273,7 @@ Note: the `--ingress-class` flag cannot be used at the same time as a `kubernete If you use annotations to indicate different ingress classes in your cluster, you can instead use an `--annotation-filter` flag to restrict which objects ExternalDNS considers; for example, `--annotation-filter=kubernetes.io/ingress.class in (public,dmz)`. -However, beware when using annotation filters with multiple sources, e.g. `--source=service --source=ingress`, since `--annotation-filter` will filter every given source objects. +However, beware when using annotation filters with multiple sources, e.g. `--source=service --source=ingress`, since `--annotation-filter` will filter every given source object. If you need to use annotation filters against a specific source you have to run a separated external dns service containing only the wanted `--source` and `--annotation-filter`. **Note:** Filtering based on annotation or ingress class name means that the external-dns controller will receive all resources of that kind and then filter on the client-side. diff --git a/docs/tutorials/public-private-route53.md b/docs/tutorials/public-private-route53.md index 3b950b109..9ceb43195 100644 --- a/docs/tutorials/public-private-route53.md +++ b/docs/tutorials/public-private-route53.md @@ -242,8 +242,6 @@ spec: - --registry=txt - --txt-owner-id=external-dns - --ingress-class=external-ingress - # ... or, if you use annotations for ingress classes - # - --annotation-filter=kubernetes.io/ingress.class in (external-ingress) - --aws-zone-type=public image: registry.k8s.io/external-dns/external-dns:v0.13.4 name: external-dns-public @@ -293,7 +291,7 @@ spec: For this setup to work, you need to create two Ingress definitions for your application. -At first, create public Ingress definition (make sure to un-comment either the `annotations` or `ingressClassName` lines): +At first, create a public Ingress definition (make sure to un-comment either the `annotations` or `ingressClassName` lines): ```yaml apiVersion: networking.k8s.io/v1 @@ -320,7 +318,7 @@ spec: pathType: Prefix ``` -Then create private Ingress definition (again, make sure to un-comment either the `annotations` or `ingressClassName` lines): +Then create a private Ingress definition (again, make sure to un-comment either the `annotations` or `ingressClassName` lines): ```yaml apiVersion: networking.k8s.io/v1