mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-05 17:16:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

Support GoDaddy PENDING_DNS_ACTIVE domains

Browse Source
This commit is contained in:
Malek Adawi 2023-08-22 22:36:11 +03:00
parent 7ddc9daba7
commit e312a36ba0
3 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
provider/godaddy/client.go
View File

@ -338,7 +338,7 @@ func (c *Client) UnmarshalResponse(response *http.Response, resType interface{})
func (c *Client) validate() error {
var response interface{}
if err := c.Get("/v1/domains?statuses=ACTIVE", response); err != nil {
if err := c.Get(domainsURI, response); err != nil {
return err
}

4
provider/godaddy/godaddy.go
View File

@ -44,6 +44,8 @@ var actionNames = []string{
"delete",
}
var domainsURI = "/v1/domains?statuses=ACTIVE,PENDING_DNS_ACTIVE"
// ErrRecordToMutateNotFound when ApplyChange has to update/delete and didn't found the record in the existing zone (Change with no record ID)
var ErrRecordToMutateNotFound = errors.New("record to mutate not found in current zone")
@ -154,7 +156,7 @@ func (p *GDProvider) zones() ([]string, error) {
zones := []gdZone{}
filteredZones := []string{}
if err := p.client.Get("/v1/domains?statuses=ACTIVE", &zones); err != nil {
if err := p.client.Get(domainsURI, &zones); err != nil {
return nil, err
}

20
provider/godaddy/godaddy_test.go
View File

@ -95,7 +95,7 @@ func TestGoDaddyZones(t *testing.T) {
}
// Basic zones
client.On("Get", "/v1/domains?statuses=ACTIVE").Return([]gdZone{
client.On("Get", domainsURI).Return([]gdZone{
{
Domain: "example.com",
},
@ -113,7 +113,7 @@ func TestGoDaddyZones(t *testing.T) {
client.AssertExpectations(t)
// Error on getting zones
client.On("Get", "/v1/domains?statuses=ACTIVE").Return(nil, ErrAPIDown).Once()
client.On("Get", domainsURI).Return(nil, ErrAPIDown).Once()
domains, err = provider.zones()
assert.Error(err)
assert.Nil(domains)
@ -128,7 +128,7 @@ func TestGoDaddyZoneRecords(t *testing.T) {
}
// Basic zones records
client.On("Get", "/v1/domains?statuses=ACTIVE").Return([]gdZone{
client.On("Get", domainsURI).Return([]gdZone{
{
Domain: zoneNameExampleNet,
},
@ -180,7 +180,7 @@ func TestGoDaddyZoneRecords(t *testing.T) {
client.AssertExpectations(t)
// Error on getting zones list
client.On("Get", "/v1/domains?statuses=ACTIVE").Return(nil, ErrAPIDown).Once()
client.On("Get", domainsURI).Return(nil, ErrAPIDown).Once()
zones, records, err = provider.zonesRecords(context.TODO(), false)
assert.Error(err)
assert.Nil(zones)
@ -188,7 +188,7 @@ func TestGoDaddyZoneRecords(t *testing.T) {
client.AssertExpectations(t)
// Error on getting zone records
client.On("Get", "/v1/domains?statuses=ACTIVE").Return([]gdZone{
client.On("Get", domainsURI).Return([]gdZone{
{
Domain: zoneNameExampleNet,
},
@ -204,7 +204,7 @@ func TestGoDaddyZoneRecords(t *testing.T) {
client.AssertExpectations(t)
// Error on getting zone record detail
client.On("Get", "/v1/domains?statuses=ACTIVE").Return([]gdZone{
client.On("Get", domainsURI).Return([]gdZone{
{
Domain: zoneNameExampleNet,
},
@ -227,7 +227,7 @@ func TestGoDaddyRecords(t *testing.T) {
}
// Basic zones records
client.On("Get", "/v1/domains?statuses=ACTIVE").Return([]gdZone{
client.On("Get", domainsURI).Return([]gdZone{
{
Domain: zoneNameExampleOrg,
},
@ -308,7 +308,7 @@ func TestGoDaddyRecords(t *testing.T) {
client.AssertExpectations(t)
// Error getting zone
client.On("Get", "/v1/domains?statuses=ACTIVE").Return(nil, ErrAPIDown).Once()
client.On("Get", domainsURI).Return(nil, ErrAPIDown).Once()
endpoints, err = provider.Records(context.TODO())
assert.Error(err)
assert.Nil(endpoints)
@ -345,7 +345,7 @@ func TestGoDaddyChange(t *testing.T) {
}
// Fetch domains
client.On("Get", "/v1/domains?statuses=ACTIVE").Return([]gdZone{
client.On("Get", domainsURI).Return([]gdZone{
{
Domain: zoneNameExampleNet,
},
@ -416,7 +416,7 @@ func TestGoDaddyErrorResponse(t *testing.T) {
}
// Fetch domains
client.On("Get", "/v1/domains?statuses=ACTIVE").Return([]gdZone{
client.On("Get", domainsURI).Return([]gdZone{
{
Domain: zoneNameExampleNet,
},