mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-06 17:46:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

add testutils to compare changes, im provider allow to inspect changes (#130)

Browse Source 
* add testutils to compare changes, inmemory provider allow to inspect changes

* use map instead of plan.Changes
This commit is contained in:
Yerken 2017-04-06 12:29:20 +02:00 committed by Martin Linkhorst
parent 92e59e7fd3
commit e25b792970
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
internal/testutils/endpoint.go
View File

@ -16,9 +16,7 @@ limitations under the License.
package testutils package testutils
import ( import "github.com/kubernetes-incubator/external-dns/endpoint"
"github.com/kubernetes-incubator/external-dns/endpoint"
)
/** test utility functions for endpoints verifications */ /** test utility functions for endpoints verifications */
@ -69,3 +67,9 @@ func SameEndpoints(a, b []*endpoint.Endpoint) bool {
return true return true
} }
// SamePlanChanges verifies that two set of changes are the same
func SamePlanChanges(a, b map[string][]*endpoint.Endpoint) bool {
return SameEndpoints(a["Create"], b["Create"]) && SameEndpoints(a["Delete"], b["Delete"]) &&
SameEndpoints(a["UpdateOld"], b["UpdateOld"]) && SameEndpoints(a["UpdateNew"], b["UpdateNew"])
}

6
provider/inmemory.go
View File

@ -44,7 +44,7 @@ type zone map[string][]*InMemoryRecord
// initialized as dns provider with no records // initialized as dns provider with no records
type InMemoryProvider struct { type InMemoryProvider struct {
zones map[string]zone zones map[string]zone
OnApplyChanges func() OnApplyChanges func(changes *plan.Changes)
OnRecords func() OnRecords func()
} }
@ -52,7 +52,7 @@ type InMemoryProvider struct {
func NewInMemoryProvider() *InMemoryProvider { func NewInMemoryProvider() *InMemoryProvider {
return &InMemoryProvider{ return &InMemoryProvider{
zones: map[string]zone{}, zones: map[string]zone{},
OnApplyChanges: func() {}, OnApplyChanges: func(changes *plan.Changes) {},
OnRecords: func() {}, OnRecords: func() {},
} }
} }
@ -92,7 +92,7 @@ func (im *InMemoryProvider) Records(zone string) ([]*endpoint.Endpoint, error) {
// update/delete record - record should exist // update/delete record - record should exist
// create/update/delete lists should not have overlapping records // create/update/delete lists should not have overlapping records
func (im *InMemoryProvider) ApplyChanges(zone string, changes *plan.Changes) error { func (im *InMemoryProvider) ApplyChanges(zone string, changes *plan.Changes) error {
defer im.OnApplyChanges() defer im.OnApplyChanges(changes)
if err := im.validateChangeBatch(zone, changes); err != nil { if err := im.validateChangeBatch(zone, changes); err != nil {
return err return err