Merge pull request #5388 from upsaurav12/provider/zone-id-filter#5150

test(zone_filter): improve coverage from 66.7% to 100%

provider/zone_id_filter_test.go

@@ -28,6 +28,11 @@ type zoneIDFilterTest struct {
 	expected     bool
 }
 
+type zoneIdFilterTestIsConfigured struct {
+	zoneIDFilter []string
+	expected     bool
+}
+
 func TestZoneIDFilterMatch(t *testing.T) {
 	zone := "/hostedzone/ZTST1"
 
@@ -37,6 +42,11 @@ func TestZoneIDFilterMatch(t *testing.T) {
 			zone,
 			true,
 		},
+		{
+			[]string{""},
+			zone,
+			true,
+		},
 		{
 			[]string{"/hostedzone/ZTST1"},
 			zone,
@@ -77,3 +87,31 @@ func TestZoneIDFilterMatch(t *testing.T) {
 		assert.Equal(t, tt.expected, zoneIDFilter.Match(tt.zone))
 	}
 }
+
+func TestZoneIDFilterIsConfigured(t *testing.T) {
+	for _, tt := range []zoneIdFilterTestIsConfigured{
+		{
+			[]string{""},
+			false,
+		},
+		{
+			[]string{},
+			false,
+		},
+		{
+			[]string{"/hostedzone/ZTST2"},
+			true,
+		},
+		{
+			[]string{"/hostedzone/ZTST2", "hostedzone/ZTST2"},
+			true,
+		},
+		{
+			[]string{"/ZSTS2"},
+			true,
+		},
+	} {
+		zoneIDFilter := NewZoneIDFilter(tt.zoneIDFilter)
+		assert.Equal(t, tt.expected, zoneIDFilter.IsConfigured())
+	}
+}