normalize function return and comments on exported type

This commit is contained in:
Zhang Jinghui 2019-11-14 23:55:18 +08:00
parent 30fc20fa38
commit b318f666ba
5 changed files with 6 additions and 6 deletions

View File

@ -76,6 +76,7 @@ func SameEndpoints(a, b []*endpoint.Endpoint) bool {
return true return true
} }
// SameEndpointLabels verifies that labels of the two slices of endpoints are the same
func SameEndpointLabels(a, b []*endpoint.Endpoint) bool { func SameEndpointLabels(a, b []*endpoint.Endpoint) bool {
if len(a) != len(b) { if len(a) != len(b) {
return false return false

View File

@ -370,9 +370,8 @@ func testAzureApplyChangesInternal(t *testing.T, dryRun bool, client RecordSetsC
result := results[0] result := results[0]
results = nil results = nil
return result, nil return result, nil
} else {
return dns.ZoneListResult{}, nil
} }
return dns.ZoneListResult{}, nil
}) })
mockZoneClientIterator := dns.NewZoneListResultIterator(mockZoneListResultPage) mockZoneClientIterator := dns.NewZoneListResultIterator(mockZoneListResultPage)

View File

@ -304,7 +304,7 @@ func (p *TransIPProvider) dnsEntriesAreEqual(a, b transip.DNSEntries) bool {
continue continue
} }
match += 1 match++
} }
} }

View File

@ -38,9 +38,9 @@ import (
) )
const ( const (
// The annotation used for determining if an ALB ingress is dualstack // ALBDualstackAnnotationKey is the annotation used for determining if an ALB ingress is dualstack
ALBDualstackAnnotationKey = "alb.ingress.kubernetes.io/ip-address-type" ALBDualstackAnnotationKey = "alb.ingress.kubernetes.io/ip-address-type"
// The value of the ALB dualstack annotation that indicates it is dualstack // ALBDualstackAnnotationValue is the value of the ALB dualstack annotation that indicates it is dualstack
ALBDualstackAnnotationValue = "dualstack" ALBDualstackAnnotationValue = "dualstack"
) )

View File

@ -53,7 +53,7 @@ type ingressRouteSource struct {
ingressRouteInformer extinformers.IngressRouteInformer ingressRouteInformer extinformers.IngressRouteInformer
} }
// NewIngressRouteSource creates a new ingressRouteSource with the given config. // NewContourIngressRouteSource creates a new contourIngressRouteSource with the given config.
func NewContourIngressRouteSource( func NewContourIngressRouteSource(
kubeClient kubernetes.Interface, kubeClient kubernetes.Interface,
contourClient contour.Interface, contourClient contour.Interface,