mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-06 17:46:57 +02:00
Code Issues Packages Projects Releases Wiki Activity

Define Labels type and JSON tags for ProviderSpecific fields

Browse Source 
The current example of CRD source is missing the `Labels` type
definition.  It also does not have the JSON tag for the `Name` and
`Value` fields of the `ProviderSpecificProperty` type.  As such,
creating a CRD from these types will result in errors.

This change fixes the two issues highlighted above.
This commit is contained in:
Arunesh Pandey 2023-03-06 11:39:59 -08:00
parent b3a7698554
commit b2eebecd68
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/contributing/crd-source.md
View File

@ -15,10 +15,11 @@ Here is typical example of [CRD API type](https://github.com/kubernetes-sigs/ext
type TTL int64 type TTL int64
type Targets []string type Targets []string
type ProviderSpecificProperty struct { type ProviderSpecificProperty struct {
Name string Name string `json:"name,omitempty"`
Value string Value string `json:"value,omitempty"`
} }
type ProviderSpecific []ProviderSpecificProperty type ProviderSpecific []ProviderSpecificProperty
type Labels map[string]string
type Endpoint struct { type Endpoint struct {
// The hostname of the DNS record // The hostname of the DNS record