diff --git a/dnsprovider/google.go b/dnsprovider/google.go index 5486bed4e..e33a30104 100644 --- a/dnsprovider/google.go +++ b/dnsprovider/google.go @@ -94,12 +94,10 @@ func (p *GoogleProvider) Records(zone string) ([]endpoint.Endpoint, error) { } for _, rr := range r.Rrdatas { - endpoint := endpoint.Endpoint{ + endpoints = append(endpoints, endpoint.Endpoint{ DNSName: r.Name, Target: rr, - } - - endpoints = append(endpoints, endpoint) + }) } } diff --git a/source/ingress.go b/source/ingress.go index 02c5f7837..54f40d7f8 100644 --- a/source/ingress.go +++ b/source/ingress.go @@ -59,16 +59,17 @@ func endpointsFromIngress(ing *v1beta1.Ingress) []endpoint.Endpoint { continue } for _, lb := range ing.Status.LoadBalancer.Ingress { - endpoint := endpoint.Endpoint{ - DNSName: rule.Host, - } if lb.IP != "" { - endpoint.Target = lb.IP - endpoints = append(endpoints, endpoint) + endpoints = append(endpoints, endpoint.Endpoint{ + DNSName: rule.Host, + Target: lb.IP, + }) } if lb.Hostname != "" { - endpoint.Target = lb.Hostname - endpoints = append(endpoints, endpoint) + endpoints = append(endpoints, endpoint.Endpoint{ + DNSName: rule.Host, + Target: lb.Hostname, + }) } } } diff --git a/source/service.go b/source/service.go index 198bb7157..3e6abcc56 100644 --- a/source/service.go +++ b/source/service.go @@ -80,18 +80,16 @@ func endpointsFromService(svc *v1.Service) []endpoint.Endpoint { // Create a corresponding endpoint for each configured external entrypoint. for _, lb := range svc.Status.LoadBalancer.Ingress { if lb.IP != "" { - endpoint := endpoint.Endpoint{ + endpoints = append(endpoints, endpoint.Endpoint{ DNSName: hostname, Target: lb.IP, - } - endpoints = append(endpoints, endpoint) + }) } if lb.Hostname != "" { - endpoint := endpoint.Endpoint{ + endpoints = append(endpoints, endpoint.Endpoint{ DNSName: hostname, Target: lb.Hostname, - } - endpoints = append(endpoints, endpoint) + }) } }