mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2026-05-05 06:36:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(helm): update helm schema (#5297)

Browse Source 
* fix(helm): update helm schema

* chore(helm): fix values file and update schema

* test(helm): add tests for null livenessProbe and readinessProbe

* docs(helm): update README with default readinessProbe configuration for webhook container

* fix(helm): update livenessProbe and readinessProbe schema types in values.yaml

* chore(helm): update livenessProbe and readinessProbe schema types in values.yaml

* fix(helm): correct type definitions for webhook probes and update CHANGELOG

* chore(changelog): fix typo

* fix(lint): fix linter

* fix(changelog): Fix location of change

* docs(helm): update  to reference default values for readinessProbe configuration
This commit is contained in:
semnell 2025-04-17 13:49:14 +02:00 committed by GitHub
parent 09ec020d6f
commit ad7dbb49ae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 86 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
charts/external-dns/CHANGELOG.md
View File

@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [UNRELEASED]
### Fixed
- Fixed wrong type definitions for webhook probes. ([#5297](https://github.com/kubernetes-sigs/external-dns/pull/5297)) _@semnell_
## [v1.16.1] - 2025-04-10
### Changed

12
charts/external-dns/tests/json-schema_test.yaml
View File

@ -50,3 +50,15 @@ tests:
labelFilter: "mydomain.io/enable-dns-record in (true)"
asserts:
- notFailedTemplate: {}
- it: should not fail when livenessProbe is null
set:
livenessProbe: null
asserts:
- notFailedTemplate: {}
- it: should not fail when readinessProbe is null
set:
readinessProbe: null
asserts:
- notFailedTemplate: {}

70
charts/external-dns/values.schema.json
View File

@ -308,30 +308,51 @@
"livenessProbe": {
"properties": {
"failureThreshold": {
"type": "integer"
"type": [
"integer",
"null"
]
},
"httpGet": {
"properties": {
"path": {
"type": "string"
"type": [
"string",
"null"
]
},
"port": {
"type": "string"
"type": [
"integer",
"string"
]
}
},
"type": "object"
},
"initialDelaySeconds": {
"type": "integer"
"type": [
"integer",
"null"
]
},
"periodSeconds": {
"type": "integer"
"type": [
"integer",
"null"
]
},
"successThreshold": {
"type": "integer"
"type": [
"integer",
"null"
]
},
"timeoutSeconds": {
"type": "integer"
"type": [
"integer",
"null"
]
}
},
"type": "object"
@ -339,30 +360,51 @@
"readinessProbe": {
"properties": {
"failureThreshold": {
"type": "integer"
"type": [
"integer",
"null"
]
},
"httpGet": {
"properties": {
"path": {
"type": "string"
"type": [
"string",
"null"
]
},
"port": {
"type": "string"
"type": [
"integer",
"string"
]
}
},
"type": "object"
},
"initialDelaySeconds": {
"type": "integer"
"type": [
"integer",
"null"
]
},
"periodSeconds": {
"type": "integer"
"type": [
"integer",
"null"
]
},
"successThreshold": {
"type": "integer"
"type": [
"integer",
"null"
]
},
"timeoutSeconds": {
"type": "integer"
"type": [
"integer",
"null"
]
}
},
"type": "object"

28
charts/external-dns/values.yaml
View File

@ -263,24 +263,24 @@ provider: # @schema type: [object, string];
# @default -- See _values.yaml_
livenessProbe:
httpGet:
path: /healthz
port: http-webhook
initialDelaySeconds: 10
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 2
successThreshold: 1
path: /healthz # @schema type:[string, null]; default: null
port: http-webhook # @schema type:[integer,string]; default: string
initialDelaySeconds: 10 # @schema type:[integer, null]; default: null
periodSeconds: 10 # @schema type:[integer, null]; default: null
timeoutSeconds: 5 # @schema type:[integer, null]; default: null
failureThreshold: 2 # @schema type:[integer, null]; default: null
successThreshold: 1 # @schema type:[integer, null]; default: null
# -- [Readiness probe](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/) configuration for the `webhook` container.
# @default -- See _values.yaml_
readinessProbe:
httpGet:
path: /healthz
port: http-webhook
initialDelaySeconds: 5
periodSeconds: 10
timeoutSeconds: 5
failureThreshold: 6
successThreshold: 1
path: /healthz # @schema type:[string, null]; default: null
port: http-webhook # @schema type:[integer,string]; default: string
initialDelaySeconds: 5 # @schema type:[integer, null]; default: null
periodSeconds: 10 # @schema type:[integer, null]; default: null
timeoutSeconds: 5 # @schema type:[integer, null]; default: null
failureThreshold: 6 # @schema type:[integer, null]; default: null
successThreshold: 1 # @schema type:[integer, null]; default: null
service:
# -- Webhook exposed HTTP port for the service.
port: 8080