From abf56c224059276f10f52bc3193fd68d4c43fba0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandor=20Sz=C3=BCcs?= Date: Sat, 2 Mar 2024 11:55:42 +0100 Subject: [PATCH] fix: possible nil ptr for invalid records like too long name MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Sandor Szücs --- provider/aws/aws.go | 3 +++ provider/aws/aws_test.go | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/provider/aws/aws.go b/provider/aws/aws.go index 7b9dc7723..b20cd760a 100644 --- a/provider/aws/aws.go +++ b/provider/aws/aws.go @@ -416,6 +416,9 @@ func (p *AWSProvider) records(ctx context.Context, zones map[string]*route53.Hos } for _, ep := range newEndpoints { + if ep == nil { + continue + } if r.SetIdentifier != nil { ep.SetIdentifier = aws.StringValue(r.SetIdentifier) switch { diff --git a/provider/aws/aws_test.go b/provider/aws/aws_test.go index ab753540a..ef7b7105d 100644 --- a/provider/aws/aws_test.go +++ b/provider/aws/aws_test.go @@ -353,6 +353,12 @@ func TestAWSRecords(t *testing.T) { TTL: aws.Int64(recordTTL), ResourceRecords: []*route53.ResourceRecord{{Value: aws.String("8.8.8.8")}}, }, + { + Name: aws.String("AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA.ext-dns-test-2.teapot.zalan.do."), + Type: aws.String(route53.RRTypeA), + TTL: aws.Int64(recordTTL), + ResourceRecords: []*route53.ResourceRecord{}, + }, { Name: aws.String("*.wildcard-test.zone-2.ext-dns-test-2.teapot.zalan.do."), Type: aws.String(route53.RRTypeA),