From a6131625cf050443066e9acb3e90d6b880dabdf9 Mon Sep 17 00:00:00 2001
From: Eric Ace <24485843+aceeric@users.noreply.github.com>
Date: Wed, 23 Jul 2025 18:01:22 -0400
Subject: [PATCH] WIP templates succesfully

---
 charts/external-dns/templates/deployment.yaml     | 9 +++++++++
 charts/external-dns/templates/service.yaml        | 2 ++
 charts/external-dns/templates/servicemonitor.yaml | 2 ++
 3 files changed, 13 insertions(+)

diff --git a/charts/external-dns/templates/deployment.yaml b/charts/external-dns/templates/deployment.yaml
index 2f49f3cb6..cce68d164 100644
--- a/charts/external-dns/templates/deployment.yaml
+++ b/charts/external-dns/templates/deployment.yaml
@@ -127,6 +127,15 @@ spec:
             - --managed-record-types={{ . }}
             {{- end }}
             - --provider={{ $providerName }}
+            {{- if .Values.provider.webhook.readTimeout }}
+            - --webhook-provider-read-timeout={{ .Values.provider.webhook.readTimeout }}
+            {{- end }}
+            {{- if .Values.provider.webhook.writeTimeout }}
+            - --webhook-provider-write-timeout={{ .Values.provider.webhook.writeTimeout }}
+            {{- end }}
+            {{- if .Values.provider.webhook.url }}
+            - --webhook-provider-url={{ .Values.provider.webhook.url }}
+            {{- end }}
             {{- if kindIs "map" .Values.extraArgs }}
             {{- range $key, $value := .Values.extraArgs }}
             {{- if not (kindIs "invalid" $value) }}
diff --git a/charts/external-dns/templates/service.yaml b/charts/external-dns/templates/service.yaml
index 882cdeb00..bb8bf4f32 100644
--- a/charts/external-dns/templates/service.yaml
+++ b/charts/external-dns/templates/service.yaml
@@ -27,6 +27,7 @@ spec:
       targetPort: http
       protocol: TCP
     {{- if eq $providerName "webhook" }}
+    {{- if .Values.provider.webhook.sidecar }}
     {{- with .Values.provider.webhook.sidecar.service }}
     - name: http-webhook
       port: {{ .port }}
@@ -34,3 +35,4 @@ spec:
       protocol: TCP
     {{- end }}
     {{- end }}
+    {{- end }}
diff --git a/charts/external-dns/templates/servicemonitor.yaml b/charts/external-dns/templates/servicemonitor.yaml
index af2d69d51..d75d54549 100644
--- a/charts/external-dns/templates/servicemonitor.yaml
+++ b/charts/external-dns/templates/servicemonitor.yaml
@@ -50,6 +50,7 @@ spec:
         {{- toYaml . | nindent 8 }}
       {{- end }}
     {{- if eq $providerName "webhook" }}
+    {{- if .Values.provider.webhook.sidecar }}
     {{- with .Values.provider.webhook.sidecar.serviceMonitor }}
     - port: http-webhook
       path: /metrics
@@ -79,6 +80,7 @@ spec:
       {{- end }}
     {{- end }}
     {{- end }}
+    {{- end }}
   {{- with .Values.serviceMonitor.targetLabels }}
   targetLabels:
     {{- toYaml . | nindent 4 }}