mirrors/external-dns
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/external-dns.git synced 2025-08-06 09:36:58 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix txt_test.go

Browse Source
This commit is contained in:
u-kai 2025-07-31 07:32:00 +09:00
parent 2601def7e8
commit a5efc4094d
No known key found for this signature in database
GPG Key ID: 03A3556244127665
1 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
registry/txt_test.go
View File

@ -1926,8 +1926,30 @@ func TestTXTRegistryRecreatesMissingRecords(t *testing.T) {
newEndpointWithOwner("record-1.test-zone.example.org", "1.1.1.1", endpoint.RecordTypeA, ownerId),
},
},
// TODO: Test TXT record regeneration when only A/CNAME records exist.
// The regeneration logic will be introduced in a separate PR.
{
name: "Should not recreate TXT records for existing A records without owner",
desired: []*endpoint.Endpoint{
newEndpointWithOwner("record-1.test-zone.example.org", "1.1.1.1", endpoint.RecordTypeA, ""),
},
existing: []*endpoint.Endpoint{
newEndpointWithOwner("record-1.test-zone.example.org", "1.1.1.1", endpoint.RecordTypeA, ownerId),
// Missing TXT record for the existing A record
},
expectedCreate: []*endpoint.Endpoint{},
},
{
name: "Should not recreate TXT records for existing A records with another owner",
desired: []*endpoint.Endpoint{
newEndpointWithOwner("record-1.test-zone.example.org", "1.1.1.1", endpoint.RecordTypeA, ""),
},
existing: []*endpoint.Endpoint{
// This test uses the `ownerId` variable, and "another-owner" simulates a different owner.
// In this case, TXT records should not be recreated.
newEndpointWithOwner("record-1.test-zone.example.org", "1.1.1.1", endpoint.RecordTypeA, "another-owner"),
newEndpointWithOwner("a-record-1.test-zone.example.org", "\"heritage=external-dns,external-dns/owner="+"another-owner"+"\"", endpoint.RecordTypeTXT, "another-owner"),
},
expectedCreate: []*endpoint.Endpoint{},
},
}
for _, tt := range tests {
for _, setIdentifier := range []string{"", "set-identifier"} {