diff --git a/provider/aws.go b/provider/aws.go index c43de0091..eb08207fe 100644 --- a/provider/aws.go +++ b/provider/aws.go @@ -382,7 +382,6 @@ func (p *AWSProvider) newChange(action string, endpoint *endpoint.Endpoint) *rou EvaluateTargetHealth: aws.Bool(evalTargetHealth), } } else if hostedZone := isAWSAlias(endpoint, rec); hostedZone != "" { - //FIXME should break if err != nil zones, err := p.Zones() if err != nil { log.Errorf("getting zones failed: %v", err) diff --git a/provider/aws_test.go b/provider/aws_test.go index 8ece0f454..7a0302942 100644 --- a/provider/aws_test.go +++ b/provider/aws_test.go @@ -835,11 +835,11 @@ func TestAWSisAWSAlias(t *testing.T) { ProviderSpecific: map[string]string{"alias": tc.alias}, } addrs := []*endpoint.Endpoint{ - &endpoint.Endpoint{ + { DNSName: "foo.example.org", Targets: endpoint.Targets{"foobar.example.org"}, }, - &endpoint.Endpoint{ + { DNSName: "bar.example.org", Targets: endpoint.Targets{"bar.eu-central-1.elb.amazonaws.com"}, },