From a2fedbc1dd9406afec73f71825e1c8ed2f84d828 Mon Sep 17 00:00:00 2001 From: Will Hegedus Date: Thu, 31 Aug 2023 19:18:55 -0400 Subject: [PATCH] fix(linode): don't try to create existing records A bug in the Linode provider can result in an unbounded explosion of TXT records being created. For example, if external-dns attempts to create a CNAME in a zone that has a conflicting A record, it will fail but will still create 2 new TXT records every single time. Instead, we can just skip creating records that already exist since they should only ever be in the list of updates. --- provider/linode/linode.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/provider/linode/linode.go b/provider/linode/linode.go index 75e2aac21..b37615d03 100644 --- a/provider/linode/linode.go +++ b/provider/linode/linode.go @@ -315,7 +315,8 @@ func (p *LinodeProvider) ApplyChanges(ctx context.Context, changes *plan.Changes "zoneName": zone.Domain, "dnsName": ep.DNSName, "recordType": ep.RecordType, - }).Warn("Records found which should not exist") + }).Warn("Records found which should not exist. Not touching it.") + continue } recordType, err := convertRecordType(ep.RecordType)