mirror of
https://github.com/kubernetes-sigs/external-dns.git
synced 2025-08-06 17:46:57 +02:00
fix some typos
This commit is contained in:
parent
65087c4e02
commit
9f28aa9106
@ -52,7 +52,7 @@ Note, how your provider doesn't need to know anything about where the DNS record
|
||||
# Running Github Actions locally
|
||||
|
||||
You can also extend the CI workflow which is currently implemented as Github Action within the [workflow](https://github.com/kubernetes-sigs/external-dns/tree/HEAD/.github/workflows) folder.
|
||||
In order to test your changes before commiting you can leverage [act](https://github.com/nektos/act) to run the Github Action locally.
|
||||
In order to test your changes before committing you can leverage [act](https://github.com/nektos/act) to run the Github Action locally.
|
||||
|
||||
Follow the installation instructions in the nektos/act [README.md](https://github.com/nektos/act/blob/master/README.md).
|
||||
Afterwards just run `act` within the root folder of the project.
|
||||
|
@ -188,7 +188,7 @@ kafka-1.example.org
|
||||
kafka-2.example.org
|
||||
```
|
||||
|
||||
If you set `--fqdn-template={{name}}.example.org` you can ommit the annotation.
|
||||
If you set `--fqdn-template={{name}}.example.org` you can omit the annotation.
|
||||
Generally it is a better approach to use `--fqdn-template={{name}}.example.org`, because then
|
||||
you would get the service name inside the generated A records:
|
||||
|
||||
|
@ -269,7 +269,7 @@ status:
|
||||
```
|
||||
|
||||
ExternalDNS will create a A-records `echoserver.example.org`, that
|
||||
use AWS ALIAS record to automatically maintain IP adresses of the NLB.
|
||||
use AWS ALIAS record to automatically maintain IP addresses of the NLB.
|
||||
|
||||
## RouteGroup (optional)
|
||||
|
||||
|
@ -128,13 +128,13 @@ func (sc *httpProxySource) Endpoints(ctx context.Context) ([]*endpoint.Endpoint,
|
||||
// Convert to []*projectcontour.HTTPProxy
|
||||
var httpProxies []*projectcontour.HTTPProxy
|
||||
for _, hp := range hps {
|
||||
unstrucuredHP, ok := hp.(*unstructured.Unstructured)
|
||||
unstructuredHP, ok := hp.(*unstructured.Unstructured)
|
||||
if !ok {
|
||||
return nil, errors.New("could not convert")
|
||||
}
|
||||
|
||||
hpConverted := &projectcontour.HTTPProxy{}
|
||||
err := sc.unstructuredConverter.scheme.Convert(unstrucuredHP, hpConverted, nil)
|
||||
err := sc.unstructuredConverter.scheme.Convert(unstructuredHP, hpConverted, nil)
|
||||
if err != nil {
|
||||
return nil, errors.Wrap(err, "failed to convert to HTTPProxy")
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user