From 959651c3366e9ef14dbe69574e7e80e40877cf18 Mon Sep 17 00:00:00 2001 From: Michel Loiseleur Date: Wed, 19 Feb 2025 14:54:44 +0100 Subject: [PATCH] chore: upgrade ExternalDNS to go 1.24 --- .github/workflows/lint.yaml | 2 +- Makefile | 2 +- cloudbuild.yaml | 2 +- docs/contributing/dev-guide.md | 4 ++-- go.mod | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml index 08c9af61e..38ad123fa 100644 --- a/.github/workflows/lint.yaml +++ b/.github/workflows/lint.yaml @@ -33,7 +33,7 @@ jobs: uses: golangci/golangci-lint-action@v6 with: args: --timeout=30m - version: v1.63 + version: v1.64 # Run Spectral - name: Lint OpenAPI spec diff --git a/Makefile b/Makefile index b1403b16d..d065bc318 100644 --- a/Makefile +++ b/Makefile @@ -41,7 +41,7 @@ CONTROLLER_GEN=$(shell which controller-gen) endif golangci-lint: - @command -v golangci-lint > /dev/null || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.63.4 + @command -v golangci-lint > /dev/null || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.64.5 # Run the golangci-lint tool .PHONY: go-lint diff --git a/cloudbuild.yaml b/cloudbuild.yaml index 5f5ecb08d..08275113d 100644 --- a/cloudbuild.yaml +++ b/cloudbuild.yaml @@ -4,7 +4,7 @@ options: substitution_option: ALLOW_LOOSE machineType: 'N1_HIGHCPU_8' steps: - - name: 'docker.io/library/golang:1.23-bookworm' + - name: 'docker.io/library/golang:1.24-bookworm' entrypoint: make env: - VERSION=$_GIT_TAG diff --git a/docs/contributing/dev-guide.md b/docs/contributing/dev-guide.md index 657098cc8..f8ac64473 100644 --- a/docs/contributing/dev-guide.md +++ b/docs/contributing/dev-guide.md @@ -7,7 +7,7 @@ The `external-dns` is the work of thousands of contributors, and is maintained b Building and/or testing `external-dns` requires additional tooling. - [Git](https://git-scm.com/downloads) -- [Go 1.23+](https://golang.org/dl/) +- [Go 1.24+](https://golang.org/dl/) - [Go modules](https://github.com/golang/go/wiki/Modules) - [golangci-lint](https://github.com/golangci/golangci-lint) - [ko](https://ko.build/) @@ -229,4 +229,4 @@ Install required dependencies. In order to not to break system packages, we are ❯❯ mkdocs serve $$ ... $$ Serving on http://127.0.0.1:8000/ -``` \ No newline at end of file +``` diff --git a/go.mod b/go.mod index 108e80489..44517b801 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module sigs.k8s.io/external-dns -go 1.23.5 +go 1.24.0 require ( cloud.google.com/go/compute/metadata v0.6.0